If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Add id for "tabs on top" menu item

VERIFIED FIXED in Firefox 4.0b2

Status

()

Firefox
Menus
VERIFIED FIXED
7 years ago
7 years ago

People

(Reporter: whimboo, Assigned: whimboo)

Tracking

Trunk
Firefox 4.0b2
Points:
---
Bug Flags:
in-testsuite -
in-litmus -

Firefox Tracking Flags

(blocking2.0 -)

Details

(Whiteboard: [mozmill])

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

7 years ago
Created attachment 455097 [details] [diff] [review]
Patch

The "Tabs on Top" menu entry under "View | Toolbars" is missing an id. We will need that for our Mozmill tests.

The following patch adds such an id.
Attachment #455097 - Flags: review?(dao)
Comment on attachment 455097 [details] [diff] [review]
Patch

Please avoid shuffling the attributes.
Attachment #455097 - Flags: review?(dao) → review-
(Assignee)

Comment 2

7 years ago
Just wanted to make sure that we are in sync with nearly all other menuitems in browser-menubar.inc. But I can revert that.
(Assignee)

Comment 3

7 years ago
Created attachment 455152 [details] [diff] [review]
Patch (without shuffling)

Patch without shuffling attributes.
Attachment #455097 - Attachment is obsolete: true
Attachment #455152 - Flags: review?
(Assignee)

Updated

7 years ago
Attachment #455152 - Flags: review? → review?(dao)

Updated

7 years ago
Attachment #455152 - Flags: review?(dao) → review+
Comment on attachment 455152 [details] [diff] [review]
Patch (without shuffling)

Thanks. I would support swapping 'command' and 'id', though...
(Assignee)

Comment 5

7 years ago
Created attachment 455160 [details] [diff] [review]
Patch for check-in

Switched id and command attributes. Taking over r+ from last review.
Attachment #455152 - Attachment is obsolete: true
Attachment #455160 - Flags: review+
(Assignee)

Updated

7 years ago
Keywords: checkin-needed

Updated

7 years ago
Summary: Add id for "tab on top" menu entry → Add id for "tabs on top" menu item
(Assignee)

Comment 6

7 years ago
Dao, can you please land this whenever you have the time? Thanks.
http://hg.mozilla.org/mozilla-central/rev/a0d03f7d55eb
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.7b2
(Assignee)

Comment 8

7 years ago
Verified fixed by MXR.
Status: RESOLVED → VERIFIED
Flags: in-testsuite-
Flags: in-litmus-
Glad it got fixed, but not a blocker.
blocking2.0: ? → -
You need to log in before you can comment on or make changes to this bug.