575962 - top window accelerated ENV variable

Status: RESOLVED FIXED

(Core :: Widget, defect)

Description

[Oleg Romashin (:romaxa)]

would be nice to have some environment variable which allow us to enable or disable accelerated mode for top-level XUL window.

something like MOZ_ACCELERATED="0"/"1"

if it is exported then it will override value in top level Xul window

It is a bit annoying to modify browser.xul every time and cleanup *.mfasl files...

What do you think about it?

Comment 1

[Oleg Romashin (:romaxa)]

Attachment: MOZ_ACCELERATED

It would be nice to have way just take upstream build and export this var...
instead of unpacking/packing chrome.jar files, cleaning up *.mfasl files e.t.c

Comment 2

[timeless]

Comment on attachment 455127 [details] [diff] [review]
MOZ_ACCELERATED

>+  const char *acceleratedEnv = PR_GetEnv("MOZ_ACCELERATED");

we generally hide this stuff behind a static....

Comment 3

[Oleg Romashin (:romaxa)]

Attachment: Make env var static

Comment 4

[Neil Lee [:neilio]]

Comment on attachment 455151 [details] [diff] [review]
Make env var static

You'll want to get a different neil to review this.

Comment 5

[[e-mail]]

Comment on attachment 455151 [details] [diff] [review]
Make env var static

>   rv = windowElement->HasAttribute(NS_LITERAL_STRING("accelerated"), &isAccelerated);
(We could move this into the else block, since we don't need to check the
attribute if the environment variable exists.)

>+    isAccelerated = *acceleratedEnv == '0' ? PR_FALSE : PR_TRUE;
Just use *acceleratedEnv != '0';

Comment 6

[Oleg Romashin (:romaxa)]

Attachment: a bit optimized by timeless suggestion

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

+    isAccelerated = *acceleratedEnv == '0' ? PR_FALSE : PR_TRUE;

isAccelerated = *acceleratedEnv != '0'

Comment 8

[Oleg Romashin (:romaxa)]

Attachment: Updated comment

Comment 9

[Oleg Romashin (:romaxa)]

http://hg.mozilla.org/mozilla-central/rev/116fc1788b1d