575976 - ARIA conformance, relation trumps role=presentation

Status: RESOLVED DUPLICATE of bug 768296

(Core :: Disability Access APIs, defect)

Description

[David Bolter [:davidb] (NeedInfo me for attention)]

Attachment: patch

It looks like the group will ask that we don't strip the h1 element in the following case:

<img role="button" src="orgchart.png" aria-labelledby="o1">
<h1 id="o1" role="presentation">placeholder</h1>

I'll hang a patch in case we need to handle this.

Comment 2

[David Bolter [:davidb] (NeedInfo me for attention)]

Attachment: updated patch (includes test)

Finally getting back to this one. Alex would you like to review?

Comment 3

[alexander :surkov (:asurkov)]

Comment on attachment 618384 [details] [diff] [review]
updated patch (includes test)

Review of attachment 618384 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/src/base/nsAccessibilityService.cpp
@@ +1067,1 @@
>        return nsnull;

note: the way you ignore presentation role in case of IsFocusable and hasRelatedContent is different. When focusable then we ignore it entirerly, in second case you create an accessbile but ignore native semantics. Which way we should do for hasRelatedContent? If the way you did then you need to comment it properly.

@@ +1219,5 @@
>    if (!newAcc && content->Tag() != nsGkAtoms::body && content->GetParent() && 
>        ((weakFrame.GetFrame() && weakFrame.GetFrame()->IsFocusable()) ||
>         (isHTML && nsCoreUtils::HasClickListener(content)) ||
>         HasUniversalAriaProperty(content) || roleMapEntry ||
> +       hasRelatedContent || HasRelatedContent(content) ||

just to be on safe side? then I'd recommend to do
hasRelatedContent || HasRelatedContent(content) || hasRelatedContent
it looks mystery ;)

Comment 4

[David Bolter [:davidb] (NeedInfo me for attention)]

Thanks for making me double check. The spec (now) says (regarding elements that should be included in the tree):

"Elements that have an ID which is referenced by another element via a WAI-ARIA relation (aria-controls, aria-describedby, aria-flowto, aria-labelledby or aria-owns), are not hidden, and do not have a role of presentation directly or inherited from an owning element."

Closing invalid.

Comment 5

[David Bolter [:davidb] (NeedInfo me for attention)]

Sigh.

Comment 7

[David Bolter [:davidb] (NeedInfo me for attention)]

I guess we'll call this one a dupe.