575993 - Sync Now and Disconnect buttons clickable before being connected

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aakash Desai [:aakashd]]

Build Id:
Mozilla/5.0 (X11; U; Linux armv71; Nokia N900; en-US; rv:2.0b2pre) Gecko/2010630 Namoroka/4.0b2pre Fennec/2.0a1pre

Note: Use a new profile or a profile that hasn't logged in to sync.

Steps to Reproduce:
1. Go to the Controls Window | Preferences
2. Scroll down to the Sync Area of the pane


Actual Results:
The Sync button and Disconnect buttons are shown and clickable even though I haven't connected yet.

Expected Results:
Both buttons should at least be hidden before connecting.

Comment 1

[Tony Chung [:tchung]]

Attachment: Sync buttons screenshot

With sync landing in prefs, the sync buttons each live in its own row.   This design is pretty fugly.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

This patch initializes the "device", "disconnect" and "sync now" rows as hidden, until the sync system connects. The code does the same thing, but since connection was delayed, all the rows were visible.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: screenshot of after connected state

Shows how the rows look after connected. They are separate (disconnect and sync now) because there is text in them.

Comment 4

[Matt Brubeck (:mbrubeck)]

Comment on attachment 455254 [details] [diff] [review]
patch

r+

In the final UI, we should do something similar with the textboxes (either collapse or disable until initialized).

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch 2

Same as previous patch, but calls WeaveGlue._updateOptions in WeaveGlue.init so the UI is updated ASAP

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
http://hg.mozilla.org/mobile-browser/rev/2cf36a20b82b

Comment 7

[Aakash Desai [:aakashd]]

verified FIXED on builds:
Mozilla/5.0 (X11; U; Linux armv71; Nokia N900; en-US; rv:2.0b2pre) Gecko/2010701 Namoroka/4.0b2pre Fennec/2.0a1pre


and fennec-electrolysis-maemo5-gtk