575999 - Context menu pops up when clicking on links

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aakash Desai [:aakashd]]

Build id:
Mozilla/5.0 (X11; U; Linux armv71; Nokia N900; en-US; rv:2.0b2pre) Gecko/2010630 Namoroka/4.0b2pre Fennec/2.0a1pre

Steps to Reproduce:
1. Go to https://bugzilla.mozilla.org/attachment.cgi?id=454539
2. Click on the link

Actual Results:
The context menu is popped up

Expected Results:
The context menu should not be popped up

Comment 1

[Matt Brubeck (:mbrubeck)]

Not just in-page links; this is happening intermittently with all sorts of links.  (Summary updated.)

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

This patch does not use the plaftorm build-in click and hold functionnality (sigh) but it does not popup everywhere!
It also turn not useful to dispatch a mousedown as soon as we have a mousedown on the chrome side.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 456448 [details] [diff] [review]
Patch

>diff -r 457ffb726aeb chrome/content/content.js

>+  _contextHoldTimeout: null,

You're using _contextTimeout everywhere else

>+  _startContextHoldTimeout: function startContextHoldTimeout(aElement) {

Rename to _startContextTimeout

I think we should disable the "ui.click_hold_context_menus" pref for now too.

I can make these changes and checkin

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
http://hg.mozilla.org/mobile-browser/rev/5e71bc8dad6b

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

missed changing the pref:
http://hg.mozilla.org/mobile-browser/rev/4e38010bf28a

Comment 7

[Aakash Desai [:aakashd]]

verified FIXED on build:
Mozilla/5.0 (X11; U; Linux armv71; Nokia N900; en-US; rv:2.0b2pre) Gecko/2010713 Namoroka/4.0b2pre Fennec/2.0a1pre