576022 - Password Manager does not fill in password immediately after selecting username

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Matt Brubeck (:mbrubeck)]

When there is more than one username/password stored for the same site, Fennec (like Firefox) offers multiple suggestions for the username field.

After choosing one of the suggestions, Firefox fills in the password field immediately (while the username field is still focused).  But Fennec does not fill in the password until the username field is unfocused.  This was confusing to at least one user (my wife) and it also means you can't just press Enter to submit the form after selecting the username.

Comment 1

[Matt Brubeck (:mbrubeck)]

Attachment: patch

LoginManager listens for both "blur" and "DOMAutoComplete":
http://mxr.mozilla.org/mozilla-central/source/toolkit/components/passwordmgr/src/nsLoginManager.js#335

In Firefox, DOMAutoComplete is fired here:
http://mxr.mozilla.org/mozilla-central/source/toolkit/components/satchel/src/nsFormFillController.cpp#455

This patch dispatches DOMAutoComplete from Form Assistant when we use autocomplete to fill a form field.  It also contains some minor code cleanup.

Comment 2

[Matt Brubeck (:mbrubeck)]

Comment on attachment 455286 [details] [diff] [review]
patch

Hmm, this is not quite working on trunk, although a similar fix does work on 1.1.  Investigating...

Comment 3

[Matt Brubeck (:mbrubeck)]

Attachment: patch v2

Use the right document for document.createEvent.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
http://hg.mozilla.org/mobile-browser/rev/d0c7ca14452e

Comment 5

[Aakash Desai [:aakashd]]

verified FIXED on build:

Mozilla/5.0 (X11; U; Linux armv71; Nokia N900; en-US; rv:2.0b2pre) Gecko/2010701 Namoroka/4.0b2pre Fennec/2.0a1pre

Comment 6

[Ioana Chiorean]

https://litmus.mozilla.org/show_test.cgi?id=15204