Closed Bug 576022 Opened 10 years ago Closed 10 years ago

Password Manager does not fill in password immediately after selecting username

Categories

(Firefox for Android Graveyard :: General, defect)

defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: mbrubeck, Assigned: mbrubeck)

Details

Attachments

(1 file, 1 obsolete file)

When there is more than one username/password stored for the same site, Fennec (like Firefox) offers multiple suggestions for the username field.

After choosing one of the suggestions, Firefox fills in the password field immediately (while the username field is still focused).  But Fennec does not fill in the password until the username field is unfocused.  This was confusing to at least one user (my wife) and it also means you can't just press Enter to submit the form after selecting the username.
Attached patch patch (obsolete) — Splinter Review
LoginManager listens for both "blur" and "DOMAutoComplete":
http://mxr.mozilla.org/mozilla-central/source/toolkit/components/passwordmgr/src/nsLoginManager.js#335

In Firefox, DOMAutoComplete is fired here:
http://mxr.mozilla.org/mozilla-central/source/toolkit/components/satchel/src/nsFormFillController.cpp#455

This patch dispatches DOMAutoComplete from Form Assistant when we use autocomplete to fill a form field.  It also contains some minor code cleanup.
Attachment #455286 - Flags: review?(mark.finkle)
Comment on attachment 455286 [details] [diff] [review]
patch

Hmm, this is not quite working on trunk, although a similar fix does work on 1.1.  Investigating...
Attachment #455286 - Flags: review?(mark.finkle)
Attached patch patch v2Splinter Review
Use the right document for document.createEvent.
Attachment #455286 - Attachment is obsolete: true
Attachment #455313 - Flags: review?(mark.finkle)
Attachment #455313 - Flags: review?(mark.finkle) → review+
pushed:
http://hg.mozilla.org/mobile-browser/rev/d0c7ca14452e
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
verified FIXED on build:

Mozilla/5.0 (X11; U; Linux armv71; Nokia N900; en-US; rv:2.0b2pre) Gecko/2010701 Namoroka/4.0b2pre Fennec/2.0a1pre
Status: RESOLVED → VERIFIED
Flags: in-testsuite?
Flags: in-litmus?
Flags: in-litmus? → in-litmus?(tchung)
https://litmus.mozilla.org/show_test.cgi?id=15204
Flags: in-litmus?(tchung) → in-litmus+
You need to log in before you can comment on or make changes to this bug.