576055 - MayHavePaintEventListener fails for e10s message manager

Status: VERIFIED FIXED

(Core :: IPC, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

Seems similar to  bug 571438, but the event fails to be generated for remote content. test-ipc.xul also appears to fail.

Comment 4

[Johnny Stenback (:jst)]

Olli, can you help the fennec guys out here? If not, please speak up.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

This seems like merge problem. MayHavePaintEventListener was fixed to
work with e10s in https://bug549223.bugzilla.mozilla.org/attachment.cgi?id=429426.

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Something like this should work. I'll test tomorrow.

-  return PR_FALSE
+  nsCOMPtr<nsPIWindowRoot> root = do_QueryInterface(parentTarget);
+  nsPIDOMEventTarget* tabChildGlobal;
+  return root &&
+         (tabChildGlobal = root->GetParentTarget()) &&
+         (manager = tabChildGlobal->GetListenerManager(PR_FALSE)) &&
+         manager->MayHavePaintEventListener();
 }

I still don't understand how this code has just disappeared from e10s.

Comment 7

[Doug Turner (:dougt)]

could have been a bad merge.  :(

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #6)
> Something like this should work. I'll test tomorrow.
> 
> -  return PR_FALSE
> +  nsCOMPtr<nsPIWindowRoot> root = do_QueryInterface(parentTarget);
> +  nsPIDOMEventTarget* tabChildGlobal;
> +  return root &&
> +         (tabChildGlobal = root->GetParentTarget()) &&
> +         (manager = tabChildGlobal->GetListenerManager(PR_FALSE)) &&
> +         manager->MayHavePaintEventListener();
>  }
> 
> I still don't understand how this code has just disappeared from e10s.

This fixes the MozAfterPaint issues for me. www.webhamsters.com show dancing hamsters!

Comment 9

[Oleg Romashin (:romaxa)]

Attachment: ok, then just fix it

Comment 10

[Oleg Romashin (:romaxa)]

works fine for me too

Comment 11

[Oleg Romashin (:romaxa)]

(In reply to comment #7)
> could have been a bad merge.  :(

don't think it is bad merge... m-c also don't have this

Comment 12

[Doug Turner (:dougt)]

Comment on attachment 455350 [details] [diff] [review]
ok, then just fix it

this was my bustage.

Comment 13

[Doug Turner (:dougt)]

http://hg.mozilla.org/projects/electrolysis/rev/5149a5980945

Comment 14

[Doug Turner (:dougt)]

http://hg.mozilla.org/mozilla-central/rev/15675470aa2d

Comment 15

[Olli Pettay [:smaug][[e-mail]]]

(In reply to comment #11)
> (In reply to comment #7)
> > could have been a bad merge.  :(
> 
> don't think it is bad merge... m-c also don't have this
m-c didn't have it because m-c didn't have the remote out-of-process 
TabChildGlobal/messageManager.

Comment 16

[Aakash Desai [:aakashd]]

verified FIXED on builds:
Mozilla/5.0 (X11; U; Linux armv71; Nokia N900; en-US; rv:2.0b2pre) Gecko/2010701 Namoroka/4.0b2pre Fennec/2.0a1pre

fennec-electrolysis-maemo5-gtk