576089 - updateInfoURI is not exposed and needs to be passed through to the resulting Addon

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Dave Townsend [:mossop]]

We don't expose the updateInfoURL property. This patch adds it to AddonInstall.infoURI and also Addon.infoURI which holds the release notes for the installed version.

Comment 1

[Dave Townsend [:mossop]]

Attachment: patch rev 1

As elsewhere I've switching this from infoURL to infoURI and made it return an nsIURI. Added some tests to make sure we can see the infoURI during update downloading and after the new version is installed.

Comment 2

[Robert Strong (they/them - no direct email)]

Comment on attachment 455267 [details] [diff] [review]
patch rev 1

>diff --git a/toolkit/mozapps/extensions/XPIProvider.jsm b/toolkit/mozapps/extensions/XPIProvider.jsm
>--- a/toolkit/mozapps/extensions/XPIProvider.jsm
>+++ b/toolkit/mozapps/extensions/XPIProvider.jsm
>@@ -3757,30 +3757,31 @@ var XPIDatabase = {
>  * @param  aName
>  *         An optional name for the add-on
>  * @param  aType
>  *         An optional type for the add-on
>  * @param  aIconURL
>  *         An optional icon for the add-on
>  * @param  aVersion
>  *         An optional version for the add-on
>- * @param  aInfoURL
>- *         An optional URL of release notes for the add-on
>+ * @param  aInfoURI
>+ *         An optional nsIURI of release notes for the add-on
As stated in bug 558834 - I think I'm ok with infoURI especially since it refers to updateInfoURL though I keep thinking that it should be releaseNoteURI. I leave that up to you.

Comment 3

[Dave Townsend [:mossop]]

(In reply to comment #2)
> (From update of attachment 455267 [details] [diff] [review])
> >diff --git a/toolkit/mozapps/extensions/XPIProvider.jsm b/toolkit/mozapps/extensions/XPIProvider.jsm
> >--- a/toolkit/mozapps/extensions/XPIProvider.jsm
> >+++ b/toolkit/mozapps/extensions/XPIProvider.jsm
> >@@ -3757,30 +3757,31 @@ var XPIDatabase = {
> >  * @param  aName
> >  *         An optional name for the add-on
> >  * @param  aType
> >  *         An optional type for the add-on
> >  * @param  aIconURL
> >  *         An optional icon for the add-on
> >  * @param  aVersion
> >  *         An optional version for the add-on
> >- * @param  aInfoURL
> >- *         An optional URL of release notes for the add-on
> >+ * @param  aInfoURI
> >+ *         An optional nsIURI of release notes for the add-on
> As stated in bug 558834 - I think I'm ok with infoURI especially since it
> refers to updateInfoURL though I keep thinking that it should be
> releaseNoteURI. I leave that up to you.

Went with releaseNotesURI throughout, I agree it makes more sense.

Comment 4

[Dave Townsend [:mossop]]

Landed: http://hg.mozilla.org/mozilla-central/rev/05dd984bb0df

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Verified fixed based on the check-in and passing automated tests. I can't verify this manually until we have the update pane and a link available.