Closed Bug 576172 Opened 14 years ago Closed 14 years ago

TM: don't try to add peers or branches if abort flushed the jit cache

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
blocking2.0 --- betaN+
status1.9.2 --- ?
status1.9.1 --- ?

People

(Reporter: gal, Assigned: luke)

Details

(Whiteboard: [sg:critical?][critsmash:patch]fixed-in-tracemonkey)

Attachments

(1 file, 2 obsolete files)

refreshed
8.54 KB, patch
gal
: review+
Details | Diff | Splinter Review 
      No description provided.
Attached patch patch (obsolete) — — Splinter Review 
Assignee: general → gal

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Fixed patch (obsolete)
        — 
          — Splinter Review
      

    


  
This one works better!

        Attachment #455346 -
        Attachment is obsolete: true

    
    

    
  
gal, can you push this through?

    
  
blocking1.9.2: --- → ?
blocking2.0: --- → ?

    
  

        Attachment #455521 -
        Flags: review?(lw)

    
  

        Attachment #455521 -
        Flags: review?(lw) → review+

    
    

    
  
landed, and why is this restricted?
Whiteboard: [sg:critical?]

    
    

    
  
Why is this sg:critical? (or, why do we need to take it on the stable branch?) If we need it how risk is the patch?

Since you're not nominating for the 1.9.1 branch does that make this a regression from something? Do we know what or are we guessing?

    
    

    
  
andreas: ping?
Whiteboard: [sg:critical?] → [sg:critical?][critsmash:patch]

    
  
blocking2.0: ? → betaN+

    
  
blocking1.9.2: ? → ---

    
    

    
  
Robert: what did you mean in comment 4 by "landed"? Should this bug be marked "fixed-in-tracemonkey" then, and presumably has gotten into the trunk by now?

    
  
Assignee: gal → bent.mozilla

    
    

    
  
bent, did this get fixed? I think I landed it.

          status1.9.1:
          --- → ?

          status1.9.2:
          --- → ?

    
    

    
  
What does "Version: Other Branch" mean? it was checked into Trunk apparently. Does the bug affect the older branches as well? All of them? just 1.9.2?

Is there a testcase QA can use to verify this?

    
    

    
  
(In reply to comment #8)
> bent, did this get fixed? I think I landed it.

it doesn't look like it.

    
    

    
  
Oh, and this is Andreas' patch. I just tidied it up a little.
Assignee: bent.mozilla → gal
Status: NEW → ASSIGNED

    
    

    
  
Can somebody just land this? Please?

    
    

    
  
Still needs landing.

Are the 1.9.2 and/or 1.9.1 branches affected?
blocking1.9.1: --- → ?
blocking1.9.2: --- → ?
Whiteboard: [sg:critical?][critsmash:patch] → [sg:critical?][critsmash:patch][needs landing][needs answer about branches]
Version: Other Branch → Trunk

    
    

    
  
The patch doesn't apply anymore. It needs to be updated.
Keywords: checkin-needed
blocking1.9.1: ? → ---
blocking1.9.2: ? → ---

    
    

    
  
Ben, can you please un-bitrot this?  I know it's not yours, but we need help.
Assignee: gal → bent.mozilla

    
    

    
  
(In reply to comment #15)
> Ben, can you please un-bitrot this?  I know it's not yours, but we need help.

No. I would if I could but I can't, this isn't a simple un-rot. Looks like the functions involved have been renamed (not so tough to fix) and now return several different values rather than true/false (more tough to fix). This needs a JS person to merge, sorry.

I'll see if I can't corner gal today.
Assignee: bent.mozilla → general

    
    

    
  
Luke has volunteered to fix this!
Assignee: general → lw

    
    

    
  

      
      
      
      

        Attached patch
          
          
        refreshed
        — 
          — Splinter Review
      

    


  
The same issue affects 1.9.1 and 1.9.2.  Actually, the original patch should more cleanly apply to those branches.

        Attachment #455521 -
        Attachment is obsolete: true

        Attachment #479225 -
        Flags: review?(gal)

    
    

    
  
Comment on attachment 479225 [details] [diff] [review]
refreshed

Nice. This fixed the bug more narrowly. We can see if bent can still reproduce this.

        Attachment #479225 -
        Flags: review?(gal) → review+

    
    

    
  
http://hg.mozilla.org/tracemonkey/rev/7c1d01933899
Whiteboard: [sg:critical?][critsmash:patch][needs landing][needs answer about branches] → [sg:critical?][critsmash:patch]fixed-in-tracemonkey

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/7c1d01933899
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Group: core-security

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: