57619 - disable http uncompress when saving to disk....

Status: VERIFIED FIXED

(SeaMonkey :: General, defect, P3)

Description

[Scott MacGregor]

This is a spin off from rtm need info Bug #35956. I'm spinning it off so I can
check in my part of the fix tonight under this bug while Gagan's team works on
the rest of the bug in the original 35956.

When downloading content through the exthandler dialog, we need to explicitly
tell http to disable auto decompression of the content.

Because we aren't doing this, the content is automatically getting uncompressed.
This leads to problems! Consider the case where you click on a gzip'ed file:
mozilla.tar.gz.

Saving that to disk currently causes us to uncompress the data but leave the
original .gz file extension on there.

so you are left with a file ending in .gz which really isn't compressed anymore.
I have a fix to set this flag on the http channel before saving it to disk.

Comment 1

[Scott MacGregor]

Attachment: the fix

Comment 2

[Scott MacGregor]

this patch was r=gagan
sr=rpotts.

The bug that depends on this is already rtm need info. So moving this to rtm+.
Hopefully we can get it checked in before Monday's builds were things get even
harder to get stuff in.

I put my part of the fix into a sepate bug from 35956 in order to try to make
sure it gets in before Monday. It's up to the necko group to track down the rest
of the problems in 35956.

Comment 3

[selmer (gone)]

rtm++

Comment 4

[Scott MacGregor]

Fix checked into the branch and the tip.

This only works for windows only.

to test, go to www.mozilla.org and click on the nightly linux tarball. When
prompted with the unknown content dialog, save it to disk.

Now look at the file. Before the fix, the file will be uncompressed. AFter the
fix, the file is properly still gziped. I compared the file sizes in order to
verify the fix. 

Comment 5

[Doron Rosenberg (IBM)]

verified win98 200102604 trunk. I downloaded the file, opened it in winzip,
which told me that it only contains only one file (embed-i686-pc-linux-gnu.tar,
no .gz

perhaps someone should check this on branch as well.

Comment 6

[Asa Dotzler [:asa]]

*** Bug 58846 has been marked as a duplicate of this bug. ***