Closed
Bug 576214
Opened 15 years ago
Closed 15 years ago
stack.js modifications for 4.5
Categories
(Developer Infrastructure :: Source Code Analysis, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: ehren.m, Assigned: ehren.m)
Details
Attachments
(2 files, 2 obsolete files)
|
32.23 KB,
text/plain
|
Details | |
|
7.26 KB,
patch
|
ehren.m
:
review+
|
Details | Diff | Splinter Review |
For a couple of reasons, porting the walk_tree portion of stack.js to 4.5 wasn't quite feasible. Reading the old bugs on this analysis, it was once implemented using a similar technique to the one I'm posting, but that was changed because of problems with COND_EXPRs. This should behave identically to the old analysis in 4.3 though.
Note: you can trick it into a false positive by writing this semi-invalid code:
StackClass* s
void *v = ::operator new(314);
s = v;
not really an issue though.
Attachment #455399 -
Flags: review?(tglek)
|
Assignee | |
Comment 1•15 years ago
|
||
this reports 48 NS_STACK_CLASS abuses, many of which are due to nsAutoString
|
||
Comment 2•15 years ago
|
||
Comment on attachment 455399 [details] [diff] [review]
patch
Looks good, might wanna document the false positive in a testcase
Attachment #455399 -
Flags: review?(tglek) → review+
|
|
Assignee | |
Comment 3•15 years ago
|
||
documents false positive (carrying over r+)
Attachment #455399 -
Attachment is obsolete: true
Attachment #466449 -
Flags: review+
|
|
Assignee | |
Comment 4•15 years ago
|
||
adding commit info
Attachment #466449 -
Attachment is obsolete: true
Attachment #466465 -
Flags: review+
|
|
||
Comment 5•15 years ago
|
||
|
|
||
Updated•15 years ago
|
Assignee: nobody → ehren.m
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
||
Updated•8 years ago
|
Product: Core → Firefox Build System
|
|
||
Updated•3 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•