576312 - firefox menu image one pixel too short

Status: RESOLVED DUPLICATE of bug 574681

(Firefox :: Theme, defect)

Description

[Asa Dotzler [:asa]]

Attachment: enlarged screenshot of firefox menu missing a row of pixels

The Firefox menu image is one pixel shorter than the Window controls. It needs one more row of horizontal pixels. 

See attached image where the window has been shrunk to show the Firefox menu overlapping the Window controls. You can see the vertical borders of the window controls extend up one more pixel than the Firefox menu's.

Comment 1

[Asa Dotzler [:asa]]

also, probably off-topic for this bug, but maybe a question for shorlander. should the Firefox menu button have the same bevel style as the Window controls? It looks a bit flat and muted compared to the Window controls.  If we do create a new image that's one pixel taller, would you consider mimicking the Window control bevel?

Comment 2

[Peter Henkel [:Terepin]]

That comes from bug 575726.

Comment 3

[Josh Tumath]

This was caused by bug 575726. It's by designer.

However, it probably would be better if it had a 1px margin-top and a white border-top.

Comment 4

[Josh Tumath]

(In reply to comment #3)
> It's by designer.

Sorry, I meant to say it's "by design".

Comment 5

[Peter Henkel [:Terepin]]

(In reply to comment #3)
> This was caused by bug 575726. It's by designer.
> 
> However, it probably would be better if it had a 1px margin-top and a white
> border-top.

Aside the fact it would be inconsistent, tell me, where do you see it:
https://wiki.mozilla.org/images/1/17/Firefox-4-Mockup-i06-%28Win7%29-%28Aero%29-%28TabsTop%29.png

Comment 6

[Josh Tumath]

(In reply to comment #5)
Ah yes, you're correct. According to the mock-up, it should have a margin-top of 1px (so that the black border is covered but the white one is visible) and on every other side, there should be two layers of borders (one black and one white).

Comment 7

[Stephen Horlander [:shorlander]]

(In reply to comment #1)
> also, probably off-topic for this bug, but maybe a question for shorlander.
> should the Firefox menu button have the same bevel style as the Window
> controls? It looks a bit flat and muted compared to the Window controls.  If we
> do create a new image that's one pixel taller, would you consider mimicking the
> Window control bevel?

I tried various levels of glossiness for the button: http://grab.by/5eeP

Since it was already orange and bright they gloss seemed a bit too much.

Comment 8

[Stephen Horlander [:shorlander]]

Attachment: Reduce Firefox margin-top by 1px

Comment 9

[Dão Gottwald [:dao]]

Comment on attachment 455619 [details] [diff] [review]
Reduce Firefox margin-top by 1px

This change alone doesn't make much sense, as it would just partly regress bug 575726. When reducing the margin we need the border to compensate this, and vice versa. Can you let your patch in bug 574681 incorporate this change?

Comment 10

[Stephen Horlander [:shorlander]]

(In reply to comment #9)
> Comment on attachment 455619 [details] [diff] [review]
> Reduce Firefox margin-top by 1px
> 
> This change alone doesn't make much sense, as it would just partly regress bug
> 575726. When reducing the margin we need the border to compensate this, and
> vice versa. Can you let your patch in bug 574681 incorporate this change?

Yes. I will update that patch to accommodate this. Thanks!

Comment 11

[Jim Mathies [:jimm]]

The way we handle this layout changed with bug 574454. I tried to pick offsets that worked best on each platform but ux folks might want to tweak.

Comment 12

[[not reading bugmail]]

(In reply to comment #10)
> (In reply to comment #9)
> > Comment on attachment 455619 [details] [diff] [review] [details]
> > Reduce Firefox margin-top by 1px
> > 
> > This change alone doesn't make much sense, as it would just partly regress bug
> > 575726. When reducing the margin we need the border to compensate this, and
> > vice versa. Can you let your patch in bug 574681 incorporate this change?
> 
> Yes. I will update that patch to accommodate this. Thanks!

I don't see this in the latest patch over there, still needed?

Comment 13

[Asa Dotzler [:asa]]

Attachment: This is still not quite right. The firefox button black border should extend to the top of the window frame.

Comment 14

[Jim Mathies [:jimm]]

(In reply to comment #13)
> Created attachment 469165 [details]
> This is still not quite right. The firefox button black border should extend to
> the top of the window frame.

http://mxr.mozilla.org/mozilla-central/source/browser/themes/winstripe/browser/browser.css#289

That's right here and can easily be changed. However I'd encourage ux folks to tweak this locally and look at it first. To me, it didn't look right.

Comment 15

[Stephen Horlander [:shorlander]]

I plan on fixing that with an updated patch to bug 574681.

Comment 16

[Asa Dotzler [:asa]]

OK. Then we can resolve this as Fixed. Thanks, everyone!