57633 - Check in big honking chatzilla patch

Status: VERIFIED FIXED

(Other Applications :: ChatZilla, defect, P3)

Description

[Robert Ginda]

Here's my proposed checkin comment.  scc, looking for sr/a= on this stuff.

Comment 1

[Robert Ginda]

* fixed 41343, tab complete still works after part.
* fixed 56708, link to rheet.wav when someone says rheet.
* fixed 40636, delete text when simleys are matched
* fixed 57138, toolbars not collapsing correctly.
* fixed 57104, link regex was kinda lame.
* fixed 54145, link completion char should be a pref.
* fixed 51352, chatzilla should remember your nick.
* cleaned up strict mode warnings.
* adjusted menu layout to make it easier to grok (i hope.)
* added "save settings now" and "save settings on exit" menu items.
* fixed invalid xul tags (<label/>) to avoid nasty warnings.
* implemented save settings functions.
* added prefs for default network, startup urls, nickname autocomplete suffix,
delete view after part, save settings on exit, stalk list, smiley text deletion.
* removed pref fot startup network/channel (replaced by startup urls.)
* added graphic for scc's ear emoticon (*
* made ui state (toolbar, userlist, statusbar visiblity) persist.

Comment 2

[Robert Ginda]

Attachment: irc.diff; proposed patch

Comment 3

[Robert Ginda]

Attachment: face-ear.gif; save to mozilla/extensions/irc/xul/skin/images/

Comment 4

[timeless]

Attachment: A slightly modified patch, because rginda's regresses the l10n features of the xul.

Comment 5

[Jacob Steenhagen]

Adding self to CC...

Comment 6

[Robert Ginda]

timeless, this is a pretty big patch... wanna give me a hint as to what you changed?

Comment 7

[timeless]

Hint: diff the two [seriously, that's how i did the work], I only changed the 
xul file patch.

you switched to <text value="hard coded string"/> instead of <text 
value="&entity;"/>

Comment 8

[Robert Ginda]

Attachment: updated chatzilla.jar for qa type people without source trees

Comment 9

[Scott Collins]

Wow!  I finally made it all the way through this patch (of 10/23/00 8:15).  It
looks good to me, particularly given the amount of testing it's had.  I already
mentioned to Rob the possible interference from the shock value of variables
named |ass|, and he did research into whether one should prefer |new Object();|
over the direct specification syntax.  Most of the changes here looked fairly
mundane (e.g., moving the |var| to better reflect the (lack of) scoping rules).
 There's some new code, but it's reasonable.  The scariest thing to me was the
change from |getElementById| to selecting out of the statusBar, since there's
not enough context just in the diff to know that's the right thing.  I really
can't find anything to complain about here.

sr=scc

Comment 10

[David Krause]

Sounds like a good time for me to mention that I've been testing this patch on
Linux and Windows for several days now.  I haven't seen any major regressions or
problems so far.  I will keep pounding on it though.

Comment 11

[Syd Logan]

r=syd, with some non-critical comments about checking createInstance consistency
and moving some stuff to strings files.

Comment 12

[Robert Ginda]

Fix checked in

Comment 13

[David Krause]

Verified