Closed Bug 576355 Opened 9 years ago Closed 9 years ago

Make configure work with clang

Categories

(Firefox Build System :: General, defect)

x86
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla2.0b2

People

(Reporter: sharparrow1, Assigned: sharparrow1)

References

Details

Attachments

(2 files)

Attached patch PatchSplinter Review
Patch attached.  Two issues here:

1. clang doesn't completely support using -Wp to pass command-line options to the preprocessor; this patch uses the proper gcc frontend options instead.

2. grepping for a specific response to using -fno-handle-exceptions as an argument isn't really a good idea; since Mozilla hasn't supported g++ 2.8 for a *very* long time, just use -fno-exceptions unconditionally.
Attachment #455533 - Flags: review?(ted.mielczarek)
Assignee: nobody → sharparrow1
Attachment #455533 - Flags: review?(ted.mielczarek) → review+
Keywords: checkin-needed
Blocks: clang-macosx
http://hg.mozilla.org/mozilla-central/rev/0e6c8cf26d7d
Status: NEW → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3b2
This patch works now for a few days without any issues, so I think we can make the same changes to comm-central. So we can also build Thunderbird and SeaMonkey with Clang.
I've made this patch by Copy&Paste and tested it with Clang and GCC (on Mac).
Is it OK like that?
Attachment #456569 - Flags: review?(bugspam.Callek)
Attachment #456569 - Flags: review?(bugspam.Callek) → review+
Keywords: checkin-needed
Whiteboard: [c-n c-c]
Happily comm-central is open now, so can anyone checkin the missing comm-central part, please. Thanks! :-)
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.