Closed
Bug 576355
Opened 16 years ago
Closed 16 years ago
Make configure work with clang
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla2.0b2
People
(Reporter: sharparrow1, Assigned: sharparrow1)
References
Details
Attachments
(2 files)
|
5.52 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
|
3.95 KB,
patch
|
Callek
:
review+
|
Details | Diff | Splinter Review |
Patch attached. Two issues here:
1. clang doesn't completely support using -Wp to pass command-line options to the preprocessor; this patch uses the proper gcc frontend options instead.
2. grepping for a specific response to using -fno-handle-exceptions as an argument isn't really a good idea; since Mozilla hasn't supported g++ 2.8 for a *very* long time, just use -fno-exceptions unconditionally.
Attachment #455533 -
Flags: review?(ted.mielczarek)
| Assignee | ||
Updated•16 years ago
|
Assignee: nobody → sharparrow1
Updated•16 years ago
|
Attachment #455533 -
Flags: review?(ted.mielczarek) → review+
| Assignee | ||
Updated•16 years ago
|
Keywords: checkin-needed
Blocks: clang-macosx
Comment 1•16 years ago
|
||
Status: NEW → RESOLVED
Closed: 16 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3b2
This patch works now for a few days without any issues, so I think we can make the same changes to comm-central. So we can also build Thunderbird and SeaMonkey with Clang.
I've made this patch by Copy&Paste and tested it with Clang and GCC (on Mac).
Is it OK like that?
Attachment #456569 -
Flags: review?(bugspam.Callek)
Updated•16 years ago
|
Attachment #456569 -
Flags: review?(bugspam.Callek) → review+
Updated•16 years ago
|
Keywords: checkin-needed
Whiteboard: [c-n c-c]
Happily comm-central is open now, so can anyone checkin the missing comm-central part, please. Thanks! :-)
Comment 4•16 years ago
|
||
Keywords: checkin-needed
Whiteboard: [c-n c-c]
Updated•8 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•