Closed
Bug 576367
Opened 14 years ago
Closed 14 years ago
Add include before use of nsIAccessible in accessible/src/base/nsAccCache.h
Categories
(Core :: Disability Access APIs, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: sharparrow1, Assigned: sharparrow1)
Details
(Whiteboard: Please checkin "Patch for commit" (addresses additional review comment))
Attachments
(2 files)
|
452 bytes,
patch
|
surkov
:
review+
|
Details | Diff | Splinter Review |
|
584 bytes,
patch
|
Details | Diff | Splinter Review |
Patch attached. Necessary for building with clang because clang is stricter about making sure nsIAccessible is defined before implicitly converting an nsIAccessible* to an nsISupports* in CycleCollectorTraverseCacheEntry.
Attachment #455543 -
Flags: review?(surkov.alexander)
Hmmm. I'm pretty sure gcc gives an error for static_cast from/to an incomplete class; it certainly should be. Or is it just a warning?
|
Assignee | |
Comment 2•14 years ago
|
||
gcc is relatively forgiving about what it accepts in template functions; see http://clang.llvm.org/compatibility.html#undep_incomplete .
Oh, I missed that it was in a template. Makes sense.
|
||
Comment 4•14 years ago
|
||
Comment on attachment 455543 [details] [diff] [review] Patch > #include "nsRefPtrHashtable.h" > #include "nsCycleCollectionParticipant.h" >- >-class nsIAccessible; >+#include "nsIAccessible.h" nit: please move this include before "nsRefPtr..." inlcude.
Attachment #455543 -
Flags: review?(surkov.alexander) → review+
|
|
Assignee | |
Comment 5•14 years ago
|
||
|
|
Assignee | |
Updated•14 years ago
|
Keywords: checkin-needed
Whiteboard: Please checkin "Patch for commit" (addresses additional review comment)
|
||
Comment 6•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/77667930fda5
You need to log in
before you can comment on or make changes to this bug.
Description
•