576375 - LayerManagerOGL::Initialize leaks p in SHADER_PROGRAM when p->Initialize fails

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[timeless]

105 LayerManagerOGL::Initialize(GLContext *aExistingContext)

134 #define SHADER_PROGRAM(penum, ptype, vsstr, fsstr) do {                 \
135     NS_ASSERTION(programIndex++ == penum, "out of order shader initialization!"); \
136     ptype *p = new ptype(mGLContext);                                   \
137     if (!p->Initialize(vsstr, fsstr))                                   \

p is leaked here:
138       return PR_FALSE;                                                  \

148   SHADER_PROGRAM(RGBALayerProgramType, ColorTextureLayerProgram,
149                  sLayerVS, sRGBATextureLayerFS);

?mark=148-149,134-138,136,137,138#105

Comment 1

[Benoit Jacob [:bjacob] (mostly away)]

This is gfx/layers code.

Comment 2

[Benoit Jacob [:bjacob] (mostly away)]

Attachment: Patch fixing this

Thanks for your report, you basically did all the work... this tiny patch fixes it, doesn't it?

Comment 3

[timeless]

Attachment: 2 space indentation slashes aligned

yeah, i filed a bunch and fell asleep before i got around to writing the patches for them.

please note that the file is using two space indentation, so your patch isn't quite proper :/.

I'm also moving the slashes on the right side because they're supposed to be aligned....

Comment 4

[timeless]

http://hg.mozilla.org/mozilla-central/rev/efdf011e85f0