Closed Bug 576421 Opened 10 years ago Closed 10 years ago

GetProxyObjectClass leaks bytes from js_DecompileValueGenerator

Categories

(Core :: JavaScript Engine, defect, minor)

defect
Not set
minor

Tracking

()

RESOLVED FIXED

People

(Reporter: timeless, Assigned: jorendorff)

References

(Blocks 1 open bug, )

Details

(Keywords: coverity, memory-leak)

753 GetProxyObjectClass(JSContext *cx, JSObject *proxy, const char **namep)

756         char *bytes = js_DecompileValueGenerator(cx, JSDVG_SEARCH_STACK,
757                                                  OBJECT_TO_JSVAL(proxy), NULL);
758         if (!bytes)
759             return JS_FALSE;
760         JS_ReportErrorNumber(cx, js_GetErrorMessage, NULL,
761                              JSMSG_UNEXPECTED_TYPE, bytes, "not a proxy");
762         return false;
Nice catch. Thanks timeless.
Actually I think I no longer use this code. timeless, can you confirm that this issue is gone from tip?
http://hg.mozilla.org/tracemonkey/rev/3aaaa21012c8
seems to have killed this
Assignee: general → jorendorff
Status: NEW → RESOLVED
Closed: 10 years ago
Depends on: compartments-api
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.