576434 - "ASSERTION: Doing nscoord addition with values > nscoord_MAX" with percentages but no large numbers

Status: RESOLVED WORKSFORME

(Core :: Layout, defect)

Description

[Jesse Ruderman]

On Windows, layout/forms/crashtests/383887-1.html triggers:

###!!! ASSERTION: Doing nscoord addition with values > nscoord_MAX: 'a < nscoord_MAX && b < nscoord_MAX', file nsCoord.h, line 216

See also bug 408772 (a previous nscoord_max bug regarding this testcase) and bug 404133 (another bug where percentages turn into ridiculously large numbers).

Comment 1

[Andreas Gal :gal]

About 90% of the assertions I get in a debug build on macosx are this one and its very annoying when debugging with fatal asserts. I am going to disable this assert. Please re-enabled it when you have a fix.

###!!! ASSERTION: Doing nscoord addition with values > nscoord_MAX: 'a < nscoord_MAX && b < nscoord_MAX', file ../../dist/include/nsCoord.h, line 216

Comment 2

[Andreas Gal :gal]

Attachment: patch

Comment 3

[Daniel Holbert [:dholbert]]

Downgrading it to a NS_WARNING would probably better than commenting it out entirely.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Yes, please change to NS_WARN_IF_FALSE rather than NS_ASSERTION.

Also, this will probably require a good bit of adjustment to reftest manifests.

We should probably also do the same thing to the other related assertions at the same time.

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

(By other related assertions, I mean the other ones that happen frequently related to saturating arithmetic.)

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Only test in the tree is commented with this bug number and its assertion annotations were removed a long time ago. Calling this WFM.