storage/test/unit/test_js_helpers.js Object.getOwnPropertyName-using tests are wrong

NEW
Unassigned

Status

()

Toolkit
Storage
P3
normal
8 years ago
a year ago

People

(Reporter: Waldo, Unassigned)

Tracking

({sec-other})

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [sg:nse])

If I uncomment the tests there, now that Object.getOwnPropertyNames is implemented in the TraceMonkey tree, they fail.  The first call returns ["a", "b", "c"], as does the second one, so the length-checking arithmetic at the end of each of the two tests fails.  I don't see why that arithmetic would be correct (I had thought these objects were to appear to be objects whose properties were the various "foo" for :foo things, but this isn't what the test expects, and there's not enough detail in the test for me to tell what it really wants), so I've removed the Object.getOwnPropertyNames check and left the test otherwise commented out.
Blocks: 562866, 429507
Whiteboard: [sg:nse]
No longer blocks: 429507
Keywords: sec-other
Priority: -- → P3
You need to log in before you can comment on or make changes to this bug.