Closed
Bug 57647
Opened 25 years ago
Closed 24 years ago
javascript strict warnings in bookmarksDD.js
Categories
(SeaMonkey :: Bookmarks & History, defect, P3)
SeaMonkey
Bookmarks & History
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla0.9.7
People
(Reporter: bugzilla, Assigned: paulkchen)
Details
Attachments
(1 file, 5 obsolete files)
|
693 bytes,
patch
|
samir_bugzilla
:
review+
bugs
:
superreview+
|
Details | Diff | Splinter Review |
JavaScript strict warning:
chrome://communicator/content/bookmarks/bookmarksDD.js line 323: redeclaration o
f var data
JavaScript strict warning:
chrome://communicator/content/bookmarks/bookmarksDD.js line 455: redeclaration o
f var nodeIndex
|
||
Comment 1•25 years ago
|
||
|
|
||
Comment 2•25 years ago
|
||
|
|
||
Comment 3•25 years ago
|
||
|
|
||
Comment 5•25 years ago
|
||
marking FIXED so QA can verify.
Status: NEW → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
|
Reporter | |
Comment 7•25 years ago
|
||
Warning: redeclaration of var flavourData
Source File: chrome://communicator/content/bookmarks/bookmarksDD.js
Line: 293, Column: 10
Source Code:
var flavourData = aXferData.dataList[i].first;
Warning: redeclaration of var rSource
Source File: chrome://communicator/content/bookmarks/bookmarksDD.js
Line: 294, Column: 10
Source Code:
var rSource = this.getResource(sourceID[i]);
Warning: redeclaration of var rParent
Source File: chrome://communicator/content/bookmarks/bookmarksDD.js
Line: 295, Column: 10
Source Code:
var rParent = parentID[i] ? this.getResource(parentID[i]) : null;
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
Summary: Lots of strict warnings in bookmarksDD.js → javascript strict warnings in bookmarksDD.js
|
||
Comment 9•24 years ago
|
||
_basic: wow, thanks for the patch, a shame it went unlooked at for so long.
r=jag on it (I'll attach a version that shows your changes more clearly, it
looks like your cvs diff got confused by line endings or something)
|
|
||
Comment 10•24 years ago
|
||
|
|
||
Updated•24 years ago
|
Attachment #50214 -
Flags: review+
|
|
||
Updated•24 years ago
|
Status: REOPENED → ASSIGNED
Target Milestone: --- → mozilla0.9.7
|
|
Reporter | |
Comment 11•24 years ago
|
||
also remember...:
Warning: redeclaration of var ix
Source File: chrome://communicator/content/bookmarks/bookmarksDD.js
Line: 336, Column: 10
Source Code:
var ix = RDFC.IndexOf(rSource);
|
|
||
Comment 12•24 years ago
|
||
Paul Chen is now taking Bookmarks bugs. For your convenience, you can filter
email notifications caused by this by searching for 'ilikegoats'.
Assignee: ben → pchen
Status: ASSIGNED → NEW
Attachment #18401 -
Attachment is obsolete: true
Attachment #18402 -
Attachment is obsolete: true
Attachment #18435 -
Attachment is obsolete: true
Attachment #42547 -
Attachment is obsolete: true
Attachment #50214 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 13•24 years ago
|
||
|
|
||
Comment 14•24 years ago
|
||
Comment on attachment 58641 [details] [diff] [review]
remove var from second 'var ix'
r=sgehani
Attachment #58641 -
Flags: review+
|
|
||
Comment 15•24 years ago
|
||
Comment on attachment 58641 [details] [diff] [review]
remove var from second 'var ix'
sr=ben@netscape.com
Attachment #58641 -
Flags: superreview+
|
|
Assignee | |
Comment 16•24 years ago
|
||
fix checked in
Status: NEW → RESOLVED
Closed: 25 years ago → 24 years ago
Resolution: --- → FIXED
|
|
||
Comment 17•24 years ago
|
||
henrik if you could do the verification honors(again) I'd appreciate that.
|
|
Reporter | |
Comment 18•24 years ago
|
||
Verified fixed in 20020115. Will reopen if I see these warnings again...
Status: RESOLVED → VERIFIED
|
||
Updated•21 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•