Refactor/unify data loading

RESOLVED FIXED

Status

Tree Management Graveyard
TBPL
RESOLVED FIXED
8 years ago
3 years ago

People

(Reporter: Swatinem, Assigned: Swatinem)

Tracking

Dependency tree / graph

Details

Attachments

(5 attachments, 2 obsolete attachments)

Comment hidden (empty)
(Assignee)

Updated

8 years ago
Blocks: 566870, 553549
Summary: Refactor → Refactor/unify data loading
(Assignee)

Comment 1

8 years ago
Created attachment 455665 [details] [diff] [review]
WIP Part1: unify datasources

WIP patch, not for review yet, just want to get some early feedback :)

The patch moves HgData, TinderboxData and Data into DatasourceClassic that treats both datasources as one unit.
It also refactors how the pushes list is generated, which means that it adds more pushes when the history button is pressed instead of replacing the whole list.

TODO items:
- implement error handling
- make updates work, they currently dont
- save the results in the datasource, currently only the results loaded last are kept alive, so refreshing the whole list when switching time zones only loads half the results
- both items above depend on merging newly loaded results, so that the UI can be refreshed based on changed items

The patch uses only tinderbox showbuilds.cgi which is slower than the current method, however it uses smaller deltas for history and updates once I implement them so the effects should be positive overall.
This also means that loading tinderbox fails more frequently, which results in the whole page being unusable, as both datasources need to succeed in order for it to work.
Attachment #455665 - Flags: feedback?(mstange)
Attachment #455665 - Flags: feedback?(ehsan)
(Assignee)

Comment 2

8 years ago
I also plan to do 2/3 more patches:
- support for multi-branch trees
- unify details/summary loading, this may not work that well with the currently very slow tinderbox based summary parser. The plan would be to pre-parse the summaries on the server once we have a real server-based datasource.
- implement “history as you scroll” and removing the loading indicators, again this makes absolutely no sense with the current datasource and is merely a preparation for when we have a fast non-failing server.
Comment on attachment 455665 [details] [diff] [review]
WIP Part1: unify datasources

Looks good to me
Attachment #455665 - Flags: feedback?(mstange) → feedback+
(Assignee)

Updated

8 years ago
Blocks: 544373
(Assignee)

Comment 4

8 years ago
Created attachment 456676 [details] [diff] [review]
WIP Part 1 v1.5: unify datasources

Just uploading my current work after the summit since I may not have the ability to work on it before I get home.
Attachment #455665 - Attachment is obsolete: true
Attachment #455665 - Flags: feedback?(ehsan)

Comment 5

8 years ago
FWIW, the WIP patch looks good to me as well, but I'm not very familiar with all of the code which this patch is changing.
(Assignee)

Comment 6

8 years ago
Created attachment 469477 [details] [diff] [review]
Kill HgData and TinderboxData

Just removes the two classes, to aid with future refactorings.
Attachment #469477 - Flags: review?(mstange)
Attachment #469477 - Flags: review?(mstange) → review+
(Assignee)

Comment 7

8 years ago
Created attachment 469521 [details] [diff] [review]
Kill HgData and TinderboxData

My patch writing skills have failed again, missed to write the right url in the commit message replace.
Attachment #469477 - Attachment is obsolete: true
Attachment #469521 - Flags: review+
(Assignee)

Comment 9

8 years ago
Created attachment 471798 [details] [diff] [review]
refactor LogId handling
Attachment #471798 - Flags: review?(mstange)
(Assignee)

Comment 10

8 years ago
Created attachment 471804 [details] [diff] [review]
treat pl and tb as a single loading unit
Attachment #471804 - Flags: review?(mstange)
Attachment #471798 - Flags: review?(mstange) → review+
Attachment #471804 - Flags: review?(mstange) → review+
(Assignee)

Comment 12

8 years ago
Created attachment 474646 [details] [diff] [review]
show loading 0% when reloading and using history
Attachment #474646 - Flags: review?(mstange)
Attachment #474646 - Flags: review?(mstange) → review+
(Assignee)

Comment 13

8 years ago
show loading 0% when reloading and using history: http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/cfaf4671cf12
(Assignee)

Comment 14

8 years ago
This is basically done now.
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Product: Webtools → Tree Management
Product: Tree Management → Tree Management Graveyard
You need to log in before you can comment on or make changes to this bug.