Closed Bug 576497 Opened 10 years ago Closed 10 years ago

TabParent::AddProgressListener leaks new TabParentListenerInfo when mListenerInfoList.AppendElement(*info) succeeds

Categories

(Core :: IPC, defect, minor)

defect
Not set
minor

Tracking

()

RESOLVED FIXED

People

(Reporter: timeless, Assigned: timeless)

References

(Blocks 1 open bug, )

Details

(Keywords: coverity, memory-leak)

Attachments

(1 file, 2 obsolete files)

551 TabParent::AddProgressListener(nsIWebProgressListener* aListener,
552                                PRUint32 aNotifyMask)

556   TabParentListenerInfo* info = GetListenerInfo(aListener);

567   info = new TabParentListenerInfo(listener, aNotifyMask);

572   rv = mListenerInfoList.AppendElement(*info) ? NS_OK : NS_ERROR_FAILURE;
573   if (NS_FAILED(rv)) {
574     delete info;
575   }
576   return rv;
Blocks: 51470
Attached patch patch (obsolete) — Splinter Review
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #455666 - Flags: review?(Olli.Pettay)
Attachment #455666 - Flags: review?(Olli.Pettay) → review+
Attached patch with missing ) (obsolete) — Splinter Review
Attachment #455666 - Attachment is obsolete: true
Attachment #456277 - Flags: review+
sorry for the bad iteration. I finally got my mac building w/ ipc. I'll run w/ this, push through try and push, hopefully this bug will be closed today.
Attachment #456277 - Attachment is obsolete: true
Attachment #456420 - Flags: review+
http://hg.mozilla.org/mozilla-central/rev/4a48e21eb70d
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.