576554 - Need manifests to register XPCOM components on trunk

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Philipp von Weitershausen [:philikon]]

With bug 568691, XPCOM components now need manifests to be registered. services/ was fixed on mozilla-central in http://hg.mozilla.org/mozilla-central/rev/05b326ca0396. It would be good to replicate this in fx-sync as not to have diverging codebases.

Comment 1

[Philipp von Weitershausen [:philikon]]

Attachment: Part 1: Provide manifests and NSGetFactory

Provide manifest files for JS-based components to match what has landed on mozilla-central already (http://hg.mozilla.org/mozilla-central/rev/05b326ca0396) and declare NSGetFactory when possible. Amend chrome.manifest for the add-on case.

Note that extensions no longer can observe app-startup (https://developer.mozilla.org/en/XPCOM/XPCOM_changes_in_Gecko_2.0#Extension_components_are_started_later) which we do in Weave.js. We don't do anything vital for the add-on there, though. The call to addResourceAlias() is only relevant when integrated into the app and the final-ui-startup observer is quite pointless IMHO since the app's XUL overlays already import service.js anyway. I think we should get rid of that code, leaving WeaveService only to add the resource alias in the non-addon case.

Comment 2

[Philipp von Weitershausen [:philikon]]

Attachment: Part 1 (v1.1): Provide manifests and NSGetFactory

Minor update: Use trailing slash for the resource alias to match what bug 576689 does.

Comment 3

[Mike Connor [:mconnor]]

Attachment: part 2: fix addonglue/aboutweavetabs/accidental commit of some monkeying

This fixes remaining trunk bustage.

Comment 4

[Philipp von Weitershausen [:philikon]]

1.4.x branch:
part 1: http://hg.mozilla.org/services/fx-sync/rev/b8bad1774876
part 2: http://hg.mozilla.org/services/fx-sync/rev/90a1abf5e231

tip:
part 1: http://hg.mozilla.org/services/fx-sync/rev/d2f3b9702dcf
part 2 AFAICT hasn't been checked into tip yet

Comment 5

[Philipp von Weitershausen [:philikon]]

part 3 on 1.4.x branch (not landed on default yet): http://hg.mozilla.org/services/fx-sync/rev/bc05c7027b61

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

Are there parts of this bug that still need to land on m-c?

Comment 8

[Philipp von Weitershausen [:philikon]]

(In reply to comment #7)
> Are there parts of this bug that still need to land on m-c?

No. Even though part 2 and 3 haven't even made the fx-sync default branch yet, they're completely add-on specific. As far as m-c is concerned this is fixed.

Comment 9

[Ed Lee :Mardak]

Comment on attachment 455886 [details] [diff] [review]
part 2: fix addonglue/aboutweavetabs/accidental commit of some monkeying

>+++ b/addon/AddonGlue.js
> 
For the other components, we have "// Gecko <2.0" here 
> function NSGetModule(compMgr, fileSpec) {
>   return XPCOMUtils.generateModule([AddonGlue]);
> }
>+// Gecko >=2.0

>+++ b/ui/firefox/AboutWeaveTabs.js
> 
> function NSGetModule(compMgr, fileSpec) {
Here too

Comment 10

[Philipp von Weitershausen [:philikon]]

Also, what about part 3? http://hg.mozilla.org/services/fx-sync/rev/bc05c7027b61

Comment 11

[Ed Lee :Mardak]

http://hg.mozilla.org/services/fx-sync/rev/6dcb99514798
Combined part 2 and 3.