576568 - [ACR Extension] Update Compatibility Reporter for XPCOM component registration changes

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Compatibility Tools, defect)

Description

[Jesse Ruderman]

The "Add-on Compatibility Reporter" extension is busted on trunk.  It spews stuff like "acr(1): Invalid pref: addons" to my console and can't submit reports.

There was a change to XPCOM registration this week, and ACR has a JS XPCOM component, so the extension probably just needs the mechanical tweak:
https://developer.mozilla.org/en/XPCOM/XPCOM_changes_in_Gecko_1.9.3

I have:
* Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:2.0b2pre) Gecko/20100701 Firefox/4.0b2pre
* ACR 0.5

Comment 1

[Philipp von Weitershausen [:philikon]]

(In reply to comment #0)
> The "Add-on Compatibility Reporter" extension is busted on trunk.  It spews
> stuff like "acr(1): Invalid pref: addons" to my console and can't submit
> reports.

This looks more like bug 576492. I'm seeing the same problem in other extensions (default prefs aren't there).

Comment 2

[Jesse Ruderman]

Indeed, now that bug 576492 is fixed, the console noise is gone and I can submit compatibility reports.

The JS XPCOM component seems to be entirely about disabling EM compatibility checks.  The mechanical change might not work there because of timing issues.

Comment 3

[Benjamin Smedberg]

Hrm, Dave, does ACR hook into the EM in ways that are impossible now? Or does it use preferences to control compatibility checking behavior in the EM?

Comment 4

[Brian King [:kinger]]

(In reply to comment #2)
> The JS XPCOM component seems to be entirely about disabling EM compatibility
> checks.  The mechanical change might not work there because of timing issues.

Can you elaborate a bit more what you mean here Jesse?

Comment 5

[Brian King [:kinger]]

(In reply to comment #3)
> Hrm, Dave, does ACR hook into the EM in ways that are impossible now? Or does
> it use preferences to control compatibility checking behavior in the EM?

The latter. It just sets the following prefs (in v0.5) to false:

extensions.checkCompatibility
extensions.checkCompatibility.3.6b
extensions.checkCompatibility.3.6
extensions.checkCompatibility.3.6p
extensions.checkCompatibility.3.6pre"
extensions.checkCompatibility.3.7a
extensions.checkCompatibility.4.0b
extensions.checkCompatibility.4.0pre
extensions.checkCompatibility.4.0p

We do it on final-ui-startup.

Comment 6

[Jesse Ruderman]

"timing issues" -- the EM has already decided to load the ACR extension, so the ACR extension may have trouble influencing the EM's compatibility checks.

Comment 7

[Benjamin Smedberg]

You set them as user prefs, or as default prefs? If user prefs, doesn't that persist beyond the uninstall of ACR? If default prefs, it wouldn't persist beyond the current session and therefore it seems that it would be useless.

Comment 8

[Brian King [:kinger]]

(In reply to comment #6)
> "timing issues" -- the EM has already decided to load the ACR extension, so the
> ACR extension may have trouble influencing the EM's compatibility checks.

Right, see bug 572322 (which may well be a dupe of this). Basically a 2nd restart is required.

(In reply to comment #7)
> You set them as user prefs, or as default prefs? If user prefs, doesn't that
> persist beyond the uninstall of ACR? If default prefs, it wouldn't persist
> beyond the current session and therefore it seems that it would be useless.

It looks like these prefs are default, but somehow are not exposed as such, i.e. they don't appear in about:config before install. They do persist across sessions.

We do some cleanup when the add-on is uninstalled.

Comment 9

[Brian King [:kinger]]

Fixed:
http://viewvc.svn.mozilla.org/vc?revision=71191&view=revision

Watch for it in an imminent 0.5.1 release.

Comment 10

[Brian King [:kinger]]

0.5.1 has been released:

https://addons.mozilla.org/en-US/firefox/addon/15003/versions/

Comment 11

[Tony Mechelynck [:tonymec]]

(In reply to comment #10)
> 0.5.1 has been released:
> 
> https://addons.mozilla.org/en-US/firefox/addon/15003/versions/

...and still no SeaMonkey support <shrug />.

Comment 12

[MrX1980]

v0.5.1 is not compatible with Firefox 4.0b4 :-(

Comment 13

[Brian King [:kinger]]

(In reply to comment #12)
> v0.5.1 is not compatible with Firefox 4.0b4 :-(

Should be now.