57657 - javascript strict warnings in pref-languages.js

Status: VERIFIED FIXED

(SeaMonkey :: Preferences, defect, P5)

Description

[Henrik Gemal]

JavaScript strict warning:
chrome://communicator/content/pref/pref-languages.js line 180: reference to unde
fined property stringLangRegion[1]

JavaScript strict warning:
chrome://communicator/content/pref/pref-languages.js line 48: reference to undef
ined property window.arguments

JavaScript strict warning:
chrome://communicator/content/pref/pref-languages.js line 55: assignment to unde
clared variable prefwindow_proxy_object

JavaScript strict warning:
chrome://communicator/content/pref/pref-languages.js line 239: assignment to und
eclared variable arrayOfPrefs

JavaScript strict warning:
chrome://communicator/content/pref/pref-languages.js line 246: assignment to und
eclared variable i

JavaScript strict warning:
chrome://communicator/content/pref/pref-languages.js line 248: assignment to und
eclared variable str

JavaScript strict warning:
chrome://communicator/content/pref/pref-languages.js line 249: assignment to und
eclared variable tit

JavaScript strict warning:
chrome://communicator/content/pref/pref-languages.js line 380: assignment to und
eclared variable j

Comment 1

[Blake Ross]

-> me

Comment 2

[Henrik Gemal]

*** Bug 55570 has been marked as a duplicate of this bug. ***

Comment 3

[Blake Ross]

reassigning to matt

Comment 4

[Mark Olson]

Attachment: patch - fix up remaining warnings

Comment 5

[Mark Olson]

Most of the warnings reported have already been cleaned up.  This patch
addresses the two remaining issues.

Issues other than warnings for this file - tab cleanup and general things like
extra try{}catch{} pairs and  x = new String(); (things that ben won't like) are
still in there.  I can fix those too if asked.

Another issue for a different bug (maybe already known) is that changes to the
language list persist immediately - i.e. cancel has the same affect as ok.

Comment 6

[Mark Olson]

This patch was absorbed into a patch i adopted in 50277.  When that gets fixed,
this should be fixed as well.

Comment 7

[Mark Olson]

This was fixed along w/ the checkin for bug 50277.

Comment 8

[Henrik Gemal]

I cant see the warnings with todays build 20010619.
Will reopen if I see them again.

Please add the following line to your prefs.js file, so we could avoid all 
these strict warning fixup...:
user_pref("javascript.options.strict", true);