add support for android running multiple threads per device

RESOLVED FIXED in Q3 11 - Serrano

Status

RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: dschaffe, Assigned: dschaffe)

Tracking

unspecified
Q3 11 - Serrano
x86
Mac OS X
Bug Flags:
in-testsuite +
flashplayer-qrb +

Details

(Whiteboard: buildbot)

Attachments

(3 attachments, 2 obsolete attachments)

(Assignee)

Description

9 years ago
froyo support concurrency.  experiment with using 2+ threads per phone on android to see if the time is faster.   

especially with the n1 we may be able to make big speedup especially with a single phone to run with 2 or 3 threads.  the patch is an offshoot of 575777: supporting multiple phones.
(Assignee)

Comment 1

9 years ago
Created attachment 455741 [details] [diff] [review]
patch for mult threads per phone

experimental patch, still testing, wanted to save patch during July shutdown

Updated

9 years ago
Assignee: nobody → dschaffe
Status: NEW → ASSIGNED
Flags: flashplayer-qrb+
Target Milestone: --- → flash10.2
(Assignee)

Comment 2

9 years ago
Created attachment 457914 [details] [diff] [review]
patch to add android threads
Attachment #455741 - Attachment is obsolete: true
Attachment #457914 - Flags: review?(brbaker)

Comment 3

9 years ago
Comment on attachment 457914 [details] [diff] [review]
patch to add android threads

I have a couple tweaks to this patch which I will post shortly
Attachment #457914 - Flags: review?(brbaker) → review+

Comment 4

9 years ago
Created attachment 458670 [details] [diff] [review]
v2. add android threading and cleanup code

This adds a little more cleanup code for restarting adb server and cleans up and displays and rogue adb processes.

Chris can you take a look at this in Dan's absence, I have pushed it through the sandbox a couple of times and has been clean.
Attachment #457914 - Attachment is obsolete: true
Attachment #458670 - Flags: review?(cpeyer)

Updated

9 years ago
Attachment #458670 - Flags: review?(cpeyer) → review+

Comment 5

9 years ago
Comment on attachment 458670 [details] [diff] [review]
v2. add android threading and cleanup code

patch pushed as 4919:7ba01b2fa39c

Comment 6

9 years ago
Created attachment 460604 [details] [diff] [review]
more tweaks to how we communicate with adb

- reboot the android devices during setup to ensure that the devices
  are in a clean state
- make sure that all devices have been rooted
- only determine the devices that are connected to the machine in
  android_shell.py if it is actually needed
- use a file object instead of PIPE when running the abc file. We have
  seen issues where adb and the python script will end up blocked when
  the stdout is _large_, this appears to have fixed the instability
  issues that we were seeing with android acceptance runs
Attachment #460604 - Flags: review?(dschaffe)
(Assignee)

Updated

9 years ago
Attachment #460604 - Flags: review?(dschaffe) → review+

Comment 7

9 years ago
Comment on attachment 460604 [details] [diff] [review]
more tweaks to how we communicate with adb

patch pushed as 4931:5bd7d99ab6ba

Updated

9 years ago
Whiteboard: buildbot

Comment 8

9 years ago
Created attachment 460872 [details] [diff] [review]
echo contents of adb_failures into stdio

Clean up the adb_failures log file and also echo the contents of the file into the buildbot stdio for the run so that it can be seen without having to log onto the machine
Attachment #460872 - Flags: review?(dschaffe)
(Assignee)

Updated

9 years ago
Attachment #460872 - Flags: review?(dschaffe) → review+

Comment 9

9 years ago
Comment on attachment 460872 [details] [diff] [review]
echo contents of adb_failures into stdio

patch pushed as 4959:a21062dff942

Comment 10

9 years ago
Marking this bug as fixed. Tracking additional 'adb' issues via bug #583022
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.