576634 - failure in tab completion matches code

Status: RESOLVED INVALID

(DevTools :: General, defect)

Description

[David Dahl :ddahl]

From irc:

<Mook_sb> oh, random stuff: http://hg.mozilla.org/users/ddahl_mozilla.com/heads-up-display/file/86da36043d1d/toolkit/components/console/hudservice/HUDService.jsm#l2239 was intermittently failing for me last night
<ddahl|away> Mook_sb: arrghh
<ddahl|away> Mook_sb: do you have the exact error?
<Mook_sb> by which I mean "wrapping that loop with a try { /* existing stuff */ } catch (e) { throw e; } fixes things"
<Mook_sb> which makes no bloody sense
<Mook_sb> sorry, not at the moment
<ddahl|away> Mook_sb: that is wacky
<Mook_sb> I think it's timing-related and on a property enum

Comment 1

[David Dahl :ddahl]

<Mook_sb> (i.e. the push call itself was safe)
<Mook_sb> also: let matches = [prop for (prop in obj)]; ;)
<Mook_sb> or even: let matches = [prop for (prop in obj) if (prop.indexOf(matchProp) == 0)];

Comment 2

[:Mook]

Sorry about the lack of detail; the actual exception appears to be:

JavaScript error: , line 0: uncaught exception: [Exception... "Component is not available"  nsresult: "0x80040111 (NS_ERROR_NOT_AVAILABLE)"  location: "JS frame :: resource://gre/modules/HUDService.jsm :: JSPropertyProvider :: line 2216"  data: no]

Which gets re-reported later:

TEST-INFO | chrome://mochikit/content/browser/toolkit/components/console/hudservice/tests/browser/browser_HUDServiceTestsAll.js | Console message: [JavaScript Error: "uncaught exception: [Exception... "Component is not available"  nsresult: "0x80040111 (NS_ERROR_NOT_AVAILABLE)"  location: "JS frame :: resource://gre/modules/HUDService.jsm :: JSPropertyProvider :: line 2216"  data: no]"]

(This is running the tests, of course)

The test then proceeds to hang.  This does *not* always occur.

Comment 3

[Julian Viereck]

(In reply to comment #1)
> <Mook_sb> (i.e. the push call itself was safe)
> <Mook_sb> also: let matches = [prop for (prop in obj)]; ;)
> <Mook_sb> or even: let matches = [prop for (prop in obj) if
> (prop.indexOf(matchProp) == 0)];

Does this fixes the problem for you?

(In reply to comment #2)
> Sorry about the lack of detail; the actual exception appears to be:
> 
> JavaScript error: , line 0: uncaught exception: [Exception... "Component is not
> available"  nsresult: "0x80040111 (NS_ERROR_NOT_AVAILABLE)"  location: "JS
> frame :: resource://gre/modules/HUDService.jsm :: JSPropertyProvider :: line
> 2216"  data: no]

What do you tip on the command line to get this error? What webpage are you serving? What's your OS?

> Which gets re-reported later:
> 
> TEST-INFO |
> chrome://mochikit/content/browser/toolkit/components/console/hudservice/tests/browser/browser_HUDServiceTestsAll.js
> | Console message: [JavaScript Error: "uncaught exception: [Exception...
> "Component is not available"  nsresult: "0x80040111 (NS_ERROR_NOT_AVAILABLE)" 
> location: "JS frame :: resource://gre/modules/HUDService.jsm ::
> JSPropertyProvider :: line 2216"  data: no]"]

I ran the tests 5 times and they passed all the time.

Comment 4

[:Mook]

Attachment: mochitest-browser-chrome log

(In reply to comment #3)
> Does this fixes the problem for you?
Sorry for the confusion - no, that is just equivalent code because that was just random chatter over IRC.

> (In reply to comment #2)

> What do you tip on the command line to get this error? What webpage are you
> serving? What's your OS?
Linux x86_64 (openSUSE 11.2), building http://hg.mozilla.org/users/ddahl_mozilla.com/heads-up-display/shortlog/86da36043d1d - running the mochitest-browser-chrome tests:

make -C toolkit/components/console/hudservice/ && TEST_PATH=toolkit/components/console/hudservice/tests/browser make mochitest-browser-chrome 2>&1 | tee run.log

Note that I'm running this over SSH with DISPLAY set to :0 (and logged in locally but not sitting at the machine).

> I ran the tests 5 times and they passed all the time.
I have no problems believing that - if it failed that frequently for you, you would have noticed already :)  Since it doesn't happen all the time for me either, it's probably just a race that my machine likes to hit.

Comment 5

[Patrick Walton (:pcwalton)]

(In reply to comment #4)

Have you seen this in recent nightlies?

Comment 6

[David Dahl :ddahl]

I would like to mark this INVALID. This is an OLD error in mochitests.

Comment 7

[Rob Campbell [:rc] (:robcee)]

OK!