576689 - Fix Sync on Android Fennec

Status: RESOLVED DUPLICATE of bug 576554

(Firefox :: Sync, defect)

Description

[Michael Wu [:mwu]]

Attachment: Fix

Due to the combination of weave landing on m-c (causing weave to enter the omnijar) and data driven compreg landing, weave no longer works on Android Fennec.

Comment 1

[Philipp von Weitershausen [:philikon]]

Comment on attachment 455811 [details] [diff] [review]
Fix

>-    let uri = ioService.newURI("resource://gre/modules/services-sync",
>+    let uri = ioService.newURI("resource://gre/modules/services-sync/",

Why is that needed?

Other than that, this duplicates stuff from bug 576554, but that's ok. We'll just have to sort that out during the next merge of fx-sync to m-c.

Comment 2

[Michael Wu [:mwu]]

(In reply to comment #1)
> (From update of attachment 455811 [details] [diff] [review])
> >-    let uri = ioService.newURI("resource://gre/modules/services-sync",
> >+    let uri = ioService.newURI("resource://gre/modules/services-sync/",
> 
> Why is that needed?
> 
I think the / is required when resolving something in a jaruri. It might be ok when dealing with a local file, but I suspect that without the /, something like resource://services-sync/asdf ends up like resource://gre/modules/services-syncasdf instead of resource://gre/modules/services-sync/asdf. I can check but things seem to break without this.

It's also good for consistency since all the internal resource uri registration (for gre/gre-resources) uses a / at the end.

Comment 3

[Philipp von Weitershausen [:philikon]]

Fair enough! I've updated my patch for bug 576554 accordingly.