576751 - ArgValueArray not Thread-safe

Status: RESOLVED INCOMPLETE

(Core Graveyard :: SQL, defect)

Description

[Petko D. (pdp) Petkov]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_6_4; en-us) AppleWebKit/533.16 (KHTML, like Gecko) Version/5.0 Safari/533.16
Build Identifier: 1.9.2+

By design ArgValueArray is not thread safe. Therefore when performing async calls on mozstorage connections, you get assertions similar to the following:

###!!! ASSERTION: ArgValueArray not thread-safe: '_mOwningThread.GetThread() == PR_GetCurrentThread()', file...

This doesn't cause the application to crash (as far as I can tell) but it is extremely nasty when debugging other features of the application runtime.

The situation is that it doesn't make sense for ArgValueArray to be thread-unsafe and at the same time advising programmers to use async connection calls. I think the API should change to accommodate this little quirk.

Reproducible: Always

Steps to Reproduce:
1. Make an async call on mozstorage
Actual Results:  
You get an assertion!

Expected Results:  
Since the code is perfectly fine, we should not get any assertions whatsoever in this particular area.

n/a

Comment 1

[Benjamin Smedberg]

The SQL extension and component are no longer active.