Remove nsICSSNamespaceRule

RESOLVED FIXED in mozilla5

Status

()

defect
P4
minor
RESOLVED FIXED
9 years ago
8 years ago

People

(Reporter: craig.topper, Assigned: craig.topper)

Tracking

(Blocks 1 bug)

Trunk
mozilla5
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments, 5 obsolete attachments)

(Assignee)

Description

9 years ago
This interface is only implemented by one class and doesn't need to exist.
(Assignee)

Updated

9 years ago
Blocks: deCOM
(Assignee)

Comment 1

9 years ago
Attachment #455960 - Flags: review?(dbaron)
(Assignee)

Comment 2

9 years ago
Attachment #455964 - Flags: review?(dbaron)
(Assignee)

Comment 3

9 years ago
Attachment #455964 - Attachment is obsolete: true
Attachment #455969 - Flags: review?(dbaron)
Attachment #455964 - Flags: review?(dbaron)
(Assignee)

Updated

9 years ago
Attachment #455969 - Attachment is patch: true
Attachment #455969 - Attachment mime type: application/octet-stream → text/plain
(Assignee)

Comment 4

9 years ago
DeCOMtaminates the methods left in this class. Also converts a member variable to an nsCOMPtr to remove reference counting code.
Attachment #455989 - Flags: review?(dbaron)
(Assignee)

Updated

9 years ago
Blocks: 577976
(Assignee)

Updated

9 years ago
Attachment #455989 - Attachment is obsolete: true
Attachment #455989 - Flags: review?(dbaron)
(Assignee)

Updated

9 years ago
Attachment #455960 - Flags: review?(dbaron)
(Assignee)

Updated

9 years ago
Attachment #455969 - Flags: review?(dbaron)
(Assignee)

Comment 5

8 years ago
Attachment #455960 - Attachment is obsolete: true
Attachment #518917 - Flags: review?(bzbarsky)
(Assignee)

Updated

8 years ago
Attachment #518917 - Attachment is patch: true
Attachment #518917 - Attachment mime type: application/octet-stream → text/plain
(Assignee)

Comment 6

8 years ago
Attachment #455969 - Attachment is obsolete: true
Attachment #518918 - Flags: review?(bzbarsky)
(Assignee)

Comment 7

8 years ago
Attachment #518919 - Flags: review?(bzbarsky)
(Assignee)

Comment 8

8 years ago
Attachment #518918 - Attachment is obsolete: true
Attachment #518972 - Flags: review?(bzbarsky)
Attachment #518918 - Flags: review?(bzbarsky)
Comment on attachment 518917 [details] [diff] [review]
Part 1: Rename CSSNameSpaceRuleImpl

r=me
Attachment #518917 - Flags: review?(bzbarsky) → review+
Comment on attachment 518972 [details] [diff] [review]
Part 2: Remove nsICSSNameSpaceRule

r=me
Attachment #518972 - Flags: review?(bzbarsky) → review+
Comment on attachment 518919 [details] [diff] [review]
Part 3: De-virtualize methods in NameSpaceRule

r=me.

I'd also be in favor of getting rid of that NS_New thing for namespace rules and using the constructor directly; that might let us get rid of SetPrefix and SetURLSpec, even.
Attachment #518919 - Flags: review?(bzbarsky) → review+
https://hg.mozilla.org/mozilla-central/rev/83001dcbcda7
https://hg.mozilla.org/mozilla-central/rev/d7ccd31d9c84
https://hg.mozilla.org/mozilla-central/rev/298776804644
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Priority: -- → P4
Resolution: --- → FIXED
Whiteboard: fixed-in-birch
Target Milestone: --- → mozilla2.2
You need to log in before you can comment on or make changes to this bug.