Incorrect syntax in PostScript font .h files

VERIFIED FIXED in M7

Status

()

P3
minor
VERIFIED FIXED
20 years ago
20 years ago

People

(Reporter: lennox, Assigned: dcone)

Tracking

Trunk
x86
FreeBSD
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

20 years ago
The syntax used for initializing the AFMscm arrays in the PostScript font .h
files (mozilla/gfx/src/ps/Helvetica.h, etc) is wrong.  The initializer for each
element of the array (each character) should be enclosed in its own set of curly
braces.

That is to say, it currently looks like:

AFMscm AFMHelveticaChars[] = {
32,
278.000000,
0.000000,
0.000000,
0.000000,
0.000000,
0.000000,
0.000000,
0.000000,
33,
278.000000,
0.000000,
...

while it should look like:

AFMscm AFMHelveticaChars[] = {
{32,
278.000000,
0.000000,
0.000000,
0.000000,
0.000000,
0.000000,
0.000000,
0.000000},
{33,
278.000000,
0.000000,
...

Egcs issues a warning for *each* array element that isn't bracketed properly,
with the result that the compilation output contains over three thousand
warnings.  This is by far the largest component of the build log on machines
with this compiler.  (See "View Full Log" on Linux clobber builds on Tinderbox.)

Since, according to a comment at the top of the header files, the files were
generated automatically by AFMGEN.EXE, fixing this problem should just be a
matter of fixing that program and re-generating the files.  Does that program
live anywhere in the mozilla source tree?  And where are the source files?
(Assignee)

Updated

20 years ago
Target Milestone: M6
(Assignee)

Updated

20 years ago
Status: NEW → ASSIGNED
(Assignee)

Updated

20 years ago
Target Milestone: M6 → M7
(Assignee)

Updated

20 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 20 years ago
Resolution: --- → FIXED

Updated

20 years ago
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.