Closed Bug 5769 Opened 25 years ago Closed 25 years ago

Incorrect syntax in PostScript font .h files

Categories

(Core :: Printing: Output, defect, P3)

x86
FreeBSD
defect

Tracking

()

VERIFIED FIXED

People

(Reporter: lennox, Assigned: dcone)

Details

The syntax used for initializing the AFMscm arrays in the PostScript font .h
files (mozilla/gfx/src/ps/Helvetica.h, etc) is wrong.  The initializer for each
element of the array (each character) should be enclosed in its own set of curly
braces.

That is to say, it currently looks like:

AFMscm AFMHelveticaChars[] = {
32,
278.000000,
0.000000,
0.000000,
0.000000,
0.000000,
0.000000,
0.000000,
0.000000,
33,
278.000000,
0.000000,
...

while it should look like:

AFMscm AFMHelveticaChars[] = {
{32,
278.000000,
0.000000,
0.000000,
0.000000,
0.000000,
0.000000,
0.000000,
0.000000},
{33,
278.000000,
0.000000,
...

Egcs issues a warning for *each* array element that isn't bracketed properly,
with the result that the compilation output contains over three thousand
warnings.  This is by far the largest component of the build log on machines
with this compiler.  (See "View Full Log" on Linux clobber builds on Tinderbox.)

Since, according to a comment at the top of the header files, the files were
generated automatically by AFMGEN.EXE, fixing this problem should just be a
matter of fixing that program and re-generating the files.  Does that program
live anywhere in the mozilla source tree?  And where are the source files?
Target Milestone: M6
Status: NEW → ASSIGNED
Target Milestone: M6 → M7
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.