576911 - The "before_table" hook throws "uninitialized value" errors in the web server log

Status: RESOLVED FIXED

(Bugzilla :: Administration, task)

Description

[Frédéric Buclin]

When listing components (editcomponents.cgi), the following errors appear:

editcomponents.cgi: Use of uninitialized value $template_name in concatenation (.) or string at Bugzilla/Template/Plugin/Hook.pm line 60.
editcomponents.cgi: Use of uninitialized value $type in concatenation (.) or string at Bugzilla/Template/Plugin/Hook.pm line 60.

The corresponding line in Hook.pm is:

  my $extension_template = "$path$template_name-$hook_name.$type.tmpl";

They are undefined because these variables are defined by:

    $filename =~ m/(.+)\.(.+)\.tmpl$/;
    my $template_name = $1;
    my $type = $2;

but $filename contains the name of the component instead of "list.html.tmpl". This problem doesn't occur when listing milestones or versions.

Comment 1

[Frédéric Buclin]

(In reply to comment #0)
> but $filename contains the name of the component instead of "list.html.tmpl".

Oh, I'm pretty sure this is because of this line:

$template ||= $context->stash->{component}->{name};

component.name is probably overriden by the name of the product's component, which explains why this problem only happens when listing components.

Comment 2

[Frédéric Buclin]

Marking as blocker for further investigation.

Comment 3

[Max Kanat-Alexander]

Attachment: v1

I actually can't reproduce that warning. However, does this fix it for you?

Comment 4

[Frédéric Buclin]

Comment on attachment 456208 [details] [diff] [review]
v1

It does, but now user IDs are displayed instead of login names.

Comment 5

[Frédéric Buclin]

Comment on attachment 456208 [details] [diff] [review]
v1

>+[% FOREACH my_component = product.components %]
>   [% overrides.initialowner.name.${component.name} = {

>   [% overrides.initialqacontact.name.${component.name} = {

You forgot to replace component by my_component here too.

Comment 6

[Max Kanat-Alexander]

Attachment: v2

Ah, right. :-)

Comment 7

[Frédéric Buclin]

Comment on attachment 456213 [details] [diff] [review]
v2

Now works fine. Thanks! r=LpSolit

Comment 8

[Max Kanat-Alexander]

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/
modified template/en/default/admin/components/list.html.tmpl
Committed revision 7286.

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/3.6/
modified template/en/default/admin/components/list.html.tmpl
Committed revision 7123.