576999 - AssertJS failure in testAddMozSearchProvider.js

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[Aaron Train [:aaronmt]]

MODULE: /firefox/testSearch/testAddMozSearchProvider.js  
TEST: testAddMozSearchProvider.js
FAIL: Controller.assertJS("subject.URLContainsText == true")
BRANCH: 1.9.1

This failure is as as a result of not waiting for the element to appear in the user interface before performing a search. The search keyword we are typing: 'Firefox', sometimes gets typed as 'Firefx', 'Fifox', 'Frfox'. The following patch adds the fix to the testSearchAPI.

Comment 1

[Aaron Train [:aaronmt]]

Attachment: Patch v1 - Wait for the search bar element

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Why do we need this extra check? The search bar should be present all the time. And given your example from above, only letters in the middle of Firefox sometimes don't get passed to the search bar.

Comment 3

[Aaron Train [:aaronmt]]

(In reply to comment #2)
> Why do we need this extra check? The search bar should be present all the time.
> And given your example from above, only letters in the middle of Firefox
> sometimes don't get passed to the search bar.

You're right, my mistake. Investigating.

Comment 4

[Aaron Train [:aaronmt]]

So I've been running this test a number of times as I am seeing it as recent as 07/13 and have only been able to reproduce on Linux and Shiretoko (1.9.1)

http://brasstacks.mozilla.com/couchdb/mozmill/_design/reports/_show/report/090ddcde8e9b11df9336005056a533eb

It's failing a) when the browser window is out of focus and b) As I mentioned before the search keyword we are typing into the searchbox:

'Firefox', sometimes gets typed as 'Firefx', 'Fifox', 'Frfox'

http://hg.mozilla.org/qa/mozmill-tests/file/f6b1814ebb7b/shared-modules/testSearchAPI.js#l795 

Could this be a problem with type(); ?

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Mass move of Mozmill Test related project bugs to newly created components. You can filter out those emails by using "Mozmill-Tests-to-MozillaQA" as criteria.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

This test still fails and causes the following search tests to fail too. I would suggest we disable it for now and investigate the problem.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

This only applies to 1.9.2 and 1.9.1.

Comment 8

[Aaron Train [:aaronmt]]

Attachment: Patch v1 (1.9.2/1.9.1) - disable test

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 521555 [details] [diff] [review]
Patch v1 (1.9.2/1.9.1) - disable test

Lets get this in and wait for tomorrows results.

Comment 10

[Aaron Train [:aaronmt]]

(In reply to comment #9)
> Comment on attachment 521555 [details] [diff] [review]
> Patch v1 (1.9.2/1.9.1) - disable test
> 
> Lets get this in and wait for tomorrows results.

http://hg.mozilla.org/qa/mozmill-tests/rev/7a2aa0a4cf9e - 1.9.2
http://hg.mozilla.org/qa/mozmill-tests/rev/9555aa51bd5a - 1.9.1

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to comment #10)
> > Lets get this in and wait for tomorrows results.
> 
> http://hg.mozilla.org/qa/mozmill-tests/rev/7a2aa0a4cf9e - 1.9.2
> http://hg.mozilla.org/qa/mozmill-tests/rev/9555aa51bd5a - 1.9.1

Not sure why this test hasn't been marked as not covered on litmus but I did that now. Next time please take care of it.

We will not enable this test on the old 1.9.x branches, so leave it as disabled.