AssertJS failure in testAddMozSearchProvider.js

RESOLVED FIXED

Status

Mozilla QA
Mozmill Tests
RESOLVED FIXED
8 years ago
7 years ago

People

(Reporter: aaronmt, Assigned: aaronmt)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [mozmill-test-failure], URL)

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

8 years ago
MODULE: /firefox/testSearch/testAddMozSearchProvider.js  
TEST: testAddMozSearchProvider.js
FAIL: Controller.assertJS("subject.URLContainsText == true")
BRANCH: 1.9.1

This failure is as as a result of not waiting for the element to appear in the user interface before performing a search. The search keyword we are typing: 'Firefox', sometimes gets typed as 'Firefx', 'Fifox', 'Frfox'. The following patch adds the fix to the testSearchAPI.
(Assignee)

Comment 1

8 years ago
Created attachment 456076 [details] [diff] [review]
Patch v1 - Wait for the search bar element
Attachment #456076 - Flags: review?(anthony.s.hughes)
(Assignee)

Updated

8 years ago
Whiteboard: [mozmill-test-failure]
Why do we need this extra check? The search bar should be present all the time. And given your example from above, only letters in the middle of Firefox sometimes don't get passed to the search bar.
(Assignee)

Updated

8 years ago
Attachment #456076 - Flags: review?(anthony.s.hughes)
(Assignee)

Updated

8 years ago
Attachment #456076 - Attachment is obsolete: true
(Assignee)

Comment 3

8 years ago
(In reply to comment #2)
> Why do we need this extra check? The search bar should be present all the time.
> And given your example from above, only letters in the middle of Firefox
> sometimes don't get passed to the search bar.

You're right, my mistake. Investigating.
(Assignee)

Comment 4

8 years ago
So I've been running this test a number of times as I am seeing it as recent as 07/13 and have only been able to reproduce on Linux and Shiretoko (1.9.1)

http://brasstacks.mozilla.com/couchdb/mozmill/_design/reports/_show/report/090ddcde8e9b11df9336005056a533eb

It's failing a) when the browser window is out of focus and b) As I mentioned before the search keyword we are typing into the searchbox:

'Firefox', sometimes gets typed as 'Firefx', 'Fifox', 'Frfox'

http://hg.mozilla.org/qa/mozmill-tests/file/f6b1814ebb7b/shared-modules/testSearchAPI.js#l795 

Could this be a problem with type(); ?
Mass move of Mozmill Test related project bugs to newly created components. You can filter out those emails by using "Mozmill-Tests-to-MozillaQA" as criteria.
Component: Search → Mozmill Tests
Product: Firefox → Mozilla QA
QA Contact: search → mozmill-tests
Version: 3.5 Branch → unspecified
(Assignee)

Updated

7 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → WORKSFORME
This test still fails and causes the following search tests to fail too. I would suggest we disable it for now and investigate the problem.
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
This only applies to 1.9.2 and 1.9.1.
Status: REOPENED → ASSIGNED
Hardware: x86 → All
Summary: [mozmill] AssertJS failure in testAddMozSearchProvider.js → AssertJS failure in testAddMozSearchProvider.js
(Assignee)

Comment 8

7 years ago
Created attachment 521555 [details] [diff] [review]
Patch v1 (1.9.2/1.9.1) - disable test
Attachment #521555 - Flags: review?(hskupin)
Comment on attachment 521555 [details] [diff] [review]
Patch v1 (1.9.2/1.9.1) - disable test

Lets get this in and wait for tomorrows results.
Attachment #521555 - Flags: review?(hskupin) → review+
(Assignee)

Comment 10

7 years ago
(In reply to comment #9)
> Comment on attachment 521555 [details] [diff] [review]
> Patch v1 (1.9.2/1.9.1) - disable test
> 
> Lets get this in and wait for tomorrows results.

http://hg.mozilla.org/qa/mozmill-tests/rev/7a2aa0a4cf9e - 1.9.2
http://hg.mozilla.org/qa/mozmill-tests/rev/9555aa51bd5a - 1.9.1
(In reply to comment #10)
> > Lets get this in and wait for tomorrows results.
> 
> http://hg.mozilla.org/qa/mozmill-tests/rev/7a2aa0a4cf9e - 1.9.2
> http://hg.mozilla.org/qa/mozmill-tests/rev/9555aa51bd5a - 1.9.1

Not sure why this test hasn't been marked as not covered on litmus but I did that now. Next time please take care of it.

We will not enable this test on the old 1.9.x branches, so leave it as disabled.
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.