Status

mozilla.org
Webdev
RESOLVED FIXED
8 years ago
7 years ago

People

(Reporter: jhopkins, Unassigned)

Tracking

Details

Attachments

(2 attachments)

(Reporter)

Description

8 years ago
My LDAP login (john.hopkins@mozillamessaging.com) is failing against https://ldap.mozilla.org/phonebook/

Can you check my account and/or reset my password, please?
Your account did not have access to the phonebook.  I enabled it, please try now and let me know if it doesn't work.
Assignee: server-ops → aravind
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
(Reporter)

Comment 2

8 years ago
Aravind, I still cannot login to the phonebook.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Reporter)

Comment 3

8 years ago
justdave says my LDAP record is corrupted on at least 1 of the LDAP servers.
(In reply to comment #3)
> justdave says my LDAP record is corrupted on at least 1 of the LDAP servers.

The ldap entry looks fine.  The app is somehow getting confused and throwing all sorts of errors..

To replicate the problem, go to "https://ldap.mozilla.org/phonebook/#search/john%20hopkins"
Summary: LDAP authentication failing → Can't access phone book.
Assignee: aravind → nobody
Component: Server Operations: Account Requests → Webdev
QA Contact: mrz → webdev

Updated

8 years ago
Depends on: 571881

Comment 5

8 years ago
Created attachment 458446 [details] [diff] [review]
Make output-html.inc tread carefully
Attachment #458446 - Flags: review?(abuchanan)

Updated

8 years ago
No longer depends on: 571881
Comment on attachment 458446 [details] [diff] [review]
Make output-html.inc tread carefully

Looks ok, but I didn't setup phonebook to test, so please test before pushing to production
Attachment #458446 - Flags: review?(abuchanan) → review+

Comment 7

8 years ago
I tested it on my side and it seems to run fine.

Comment 8

8 years ago
Just realized that the issue here is two-fold:
1. Some people have so little information on their entry that they cause the "offset undefined" error message(s) when they show up in a search result. The existing patch fixes that already.
2. The dot (.) character was not considered to be a valid username. A patch will shortly be attached that fixes this.

Comment 9

8 years ago
Created attachment 458798 [details] [diff] [review]
Include dot (.) as a valid character in usernames
Attachment #458798 - Flags: review?(abuchanan)
Comment on attachment 458798 [details] [diff] [review]
Include dot (.) as a valid character in usernames

I haven't tested, but if it fixes the problem then r+

It seems we have a lot of issues with this part of the app, and that parsing email addresses is more complicated than a custom regex can handle.

Check this out,
http://www.iamcal.com/publish/articles/php/parsing_email/

It explains just how difficult email regexps are, and includes code to properly split them up.  You might consider using that instead.
Attachment #458798 - Flags: review?(abuchanan) → review+
A proper way to parse email addresses would only be needed when the email addresses allowed are not under our direct control. For example, we wouldn't need to parse route-addrs per RFC 822. The only reason we're even parsing email addresses is because we need some way to represent algorithmically how IT places an entry under which O of the mozilla Domain Component, which is so far reliably predictable.
Committed r71838.
Status: REOPENED → RESOLVED
Last Resolved: 8 years ago7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.