Closed
Bug 577013
Opened 15 years ago
Closed 15 years ago
Rework GetConcreteObject and friends; return INVALID_VALUE on unexpected null objects
Categories
(Core :: Graphics: CanvasWebGL, defect)
Core
Graphics: CanvasWebGL
Tracking
()
RESOLVED
FIXED
People
(Reporter: bjacob, Assigned: bjacob)
Details
Attachments
(1 file, 1 obsolete file)
This patch does for GetConcreteObject and friends, what we recently did for the Validate... functions: take a 'info' parameter and do the GL error synthesizing, so that the caller only has to return NS_OK;
This patch also (and that was the main motivation) ensures that we generate INVALID_VALUE and not INVALID_OPERATION on unexpected null objects. This makes us pass some tests.
Finally, CheckConversion is renamed to CanGetConcreteObject.
I would have liked to pass 'info' as the last parameter, but that was impractical as we have optional parameters.
|
Assignee | |
Comment 1•15 years ago
|
||
|
|
Assignee | |
Comment 2•15 years ago
|
||
Some fixes in OBTAIN_UNIFORM_LOCATION
Attachment #456091 -
Attachment is obsolete: true
Attachment #456093 -
Flags: review?(vladimir)
Attachment #456091 -
Flags: review?(vladimir)
Attachment #456093 -
Flags: review?(vladimir) → review+
|
|
Assignee | |
Comment 3•15 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•