Closed Bug 577043 Opened 11 years ago Closed 11 years ago

ensure Gloda is in the namespaces of the windows that use Activity Manager - "Gloda is not defined" error console message from Thunderbird

Categories

(Thunderbird :: Message Reader UI, defect)

x86
All
defect
Not set
normal

Tracking

(thunderbird3.1 .7-fixed)

VERIFIED FIXED
Thunderbird 3.3a1
Tracking Status
thunderbird3.1 --- .7-fixed

People

(Reporter: olivierbaudry.eba, Assigned: standard8)

References

Details

Attachments

(1 file, 1 obsolete file)

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; fr; rv:1.9.2.6) Gecko/20100625 Firefox/3.6.6
Build Identifier: 

I just report message from console about thunderbird 

2010-07-06 00:45:29	nsActivityManager	ERROR	Exception calling onAddedActivity[Exception... "'[JavaScript Error: "Gloda is not defined" {file: "chrome://messenger/content/mailWindow.js" line: 363}]' when calling method: [nsIActivityMgrListener::onAddedActivity]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame :: file:///Applications/Thunderbird.app/Contents/MacOS/components/nsActivityManager.js :: anonymous :: line 115"  data: yes]
2010-07-06 00:45:29	nsActivityManager	ERROR	Exception calling onAddedActivity[Exception... "'[JavaScript Error: "Gloda is not defined" {file: "chrome://messenger/content/mailWindow.js" line: 363}]' when calling method: [nsIActivityMgrListener::onAddedActivity]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame :: file:///Applications/Thunderbird.app/Contents/MacOS/components/nsActivityManager.js :: anonymous :: line 115"  data: yes]
2010-07-06 00:46:28	nsActivityManager	ERROR	Exception calling onAddedActivity[Exception... "'[JavaScript Error: "Gloda is not defined" {file: "chrome://messenger/content/mailWindow.js" line: 363}]' when calling method: [nsIActivityMgrListener::onAddedActivity]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame :: file:///Applications/Thunderbird.app/Contents/MacOS/components/nsActivityManager.js :: anonymous :: line 115"  data: yes]
2010-07-06 00:46:28	nsActivityManager	ERROR	Exception calling onAddedActivity[Exception... "'[JavaScript Error: "Gloda is not defined" {file: "chrome://messenger/content/mailWindow.js" line: 363}]' when calling method: [nsIActivityMgrListener::onAddedActivity]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame :: file:///Applications/Thunderbird.app/Contents/MacOS/components/nsActivityManager.js :: anonymous :: line 115"  data: yes]
2010-07-06 00:47:29	nsActivityManager	ERROR	Exception calling onAddedActivity[Exception... "'[JavaScript Error: "Gloda is not defined" {file: "chrome://messenger/content/mailWindow.js" line: 363}]' when calling method: [nsIActivityMgrListener::onAddedActivity]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame :: file:///Applications/Thunderbird.app/Contents/MacOS/components/nsActivityManager.js :: anonymous :: line 115"  data: yes]
2010-07-06 00:47:29	nsActivityManager	ERROR	Exception calling onAddedActivity[Exception... "'[JavaScript Error: "Gloda is not defined" {file: "chrome://messenger/content/mailWindow.js" line: 363}]' when calling method: [nsIActivityMgrListener::onAddedActivity]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame :: file:///Applications/Thunderbird.app/Contents/MacOS/components/nsActivityManager.js :: anonymous :: line 115"  data: yes]
2010-07-06 00:48:30	nsActivityManager	ERROR	Exception calling onAddedActivity[Exception... "'[JavaScript Error: "Gloda is not defined" {file: "chrome://messenger/content/mailWindow.js" line: 363}]' when calling method: [nsIActivityMgrListener::onAddedActivity]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame :: file:///Applications/Thunderbird.app/Contents/MacOS/components/nsActivityManager.js :: anonymous :: line 115"  data: yes]
2010-07-06 00:48:32	nsActivityManager	ERROR	Exception calling onAddedActivity[Exception... "'[JavaScript Error: "Gloda is not defined" {file: "chrome://messenger/content/mailWindow.js" line: 363}]' when calling method: [nsIActivityMgrListener::onAddedActivity]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame :: file:///Applications/Thunderbird.app/Contents/MacOS/components/nsActivityManager.js :: anonymous :: line 115"  data: yes]
2010-07-06 00:49:01	nsActivityManager	ERROR	Exception calling onAddedActivity[Exception... "'[JavaScript Error: "Gloda is not defined" {file: "chrome://messenger/content/mailWindow.js" line: 363}]' when calling method: [nsIActivityMgrListener::onAddedActivity]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame :: file:///Applications/Thunderbird.app/Contents/MacOS/components/nsActivityManager.js :: anonymous :: line 115"  data: yes]
2010-07-06 00:49:01	nsActivityManager	ERROR	Exception calling onAddedActivity[Exception... "'[JavaScript Error: "Gloda is not defined" {file: "chrome://messenger/content/mailWindow.js" line: 363}]' when calling method: [nsIActivityMgrListener::onAddedActivity]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame :: file:///Applications/Thunderbird.app/Contents/MacOS/components/nsActivityManager.js :: anonymous :: line 115"  data: yes]
2010-07-06 00:49:14	nsActivityManager	ERROR	Exception calling onAddedActivity[Exception... "'[JavaScript Error: "Gloda is not defined" {file: "chrome://messenger/content/mailWindow.js" line: 363}]' when calling method: [nsIActivityMgrListener::onAddedActivity]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame :: file:///Applications/Thunderbird.app/Contents/MacOS/components/nsActivityManager.js :: anonymous :: line 115"  data: yes]
2010-07-06 00:49:14	nsActivityManager	ERROR	Exception calling onAddedActivity[Exception... "'[JavaScript Error: "Gloda is not defined" {file: "chrome://messenger/content/mailWindow.js" line: 363}]' when calling method: [nsIActivityMgrListener::onAddedActivity]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame :: file:///Applications/Thunderbird.app/Contents/MacOS/components/nsActivityManager.js :: anonymous :: line 115"  data: yes]
2010-07-06 00:49:31	nsActivityManager	ERROR	Exception calling onAddedActivity[Exception... "'[JavaScript Error: "Gloda is not defined" {file: "chrome://messenger/content/mailWindow.js" line: 363}]' when calling method: [nsIActivityMgrListener::onAddedActivity]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame :: file:///Applications/Thunderbird.app/Contents/MacOS/components/nsActivityManager.js :: anonymous :: line 115"  data: yes]
2010-07-06 00:49:31	nsActivityManager	ERROR	Exception calling onAddedActivity[Exception... "'[JavaScript Error: "Gloda is not defined" {file: "chrome://messenger/content/mailWindow.js" line: 363}]' when calling method: [nsIActivityMgrListener::onAddedActivity]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame :: file:///Applications/Thunderbird.app/Contents/MacOS/components/nsActivityManager.js :: anonymous :: line 115"  data: yes]
2010-07-06 00:50:29	nsActivityManager	ERROR	Exception calling onAddedActivity[Exception... "'[JavaScript Error: "Gloda is not defined" {file: "chrome://messenger/content/mailWindow.js" line: 363}]' when calling method: [nsIActivityMgrListener::onAddedActivity]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame :: file:///Applications/Thunderbird.app/Contents/MacOS/components/nsActivityManager.js :: anonymous :: line 115"  data: yes]
2010-07-06 00:50:29	nsActivityManager	ERROR	Exception calling onAddedActivity[Exception... "'[JavaScript Error: "Gloda is not defined" {file: "chrome://messenger/content/mailWindow.js" line: 363}]' when calling method: [nsIActivityMgrListener::onAddedActivity]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame :: file:///Applications/Thunderbird.app/Contents/MacOS/components/nsActivityManager.js :: anonymous :: line 115"  data: yes]


Reproducible: Always




2010-07-06 00:45:29	nsActivityManager	ERROR	Exception calling onAddedActivity[Exception... "'[JavaScript Error: "Gloda is not defined" {file: "chrome://messenger/content/mailWindow.js" line: 363}]' when calling method: [nsIActivityMgrListener::onAddedActivity]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame :: file:///Applications/Thunderbird.app/Contents/MacOS/components/nsActivityManager.js :: anonymous :: line 115"  data: yes]
2010-07-06 00:45:29	nsActivityManager	ERROR	Exception calling onAddedActivity[Exception... "'[JavaScript Error: "Gloda is not defined" {file: "chrome://messenger/content/mailWindow.js" line: 363}]' when calling method: [nsIActivityMgrListener::onAddedActivity]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame :: file:///Applications/Thunderbird.app/Contents/MacOS/components/nsActivityManager.js :: anonymous :: line 115"  data: yes]
2010-07-06 00:46:28	nsActivityManager	ERROR	Exception calling onAddedActivity[Exception... "'[JavaScript Error: "Gloda is not defined" {file: "chrome://messenger/content/mailWindow.js" line: 363}]' when calling method: [nsIActivityMgrListener::onAddedActivity]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame :: file:///Applications/Thunderbird.app/Contents/MacOS/components/nsActivityManager.js :: anonymous :: line 115"  data: yes]
2010-07-06 00:46:28	nsActivityManager	ERROR	Exception calling onAddedActivity[Exception... "'[JavaScript Error: "Gloda is not defined" {file: "chrome://messenger/content/mailWindow.js" line: 363}]' when calling method: [nsIActivityMgrListener::onAddedActivity]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame :: file:///Applications/Thunderbird.app/Contents/MacOS/components/nsActivityManager.js :: anonymous :: line 115"  data: yes]
2010-07-06 00:47:29	nsActivityManager	ERROR	Exception calling onAddedActivity[Exception... "'[JavaScript Error: "Gloda is not defined" {file: "chrome://messenger/content/mailWindow.js" line: 363}]' when calling method: [nsIActivityMgrListener::onAddedActivity]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame :: file:///Applications/Thunderbird.app/Contents/MacOS/components/nsActivityManager.js :: anonymous :: line 115"  data: yes]
2010-07-06 00:47:29	nsActivityManager	ERROR	Exception calling onAddedActivity[Exception... "'[JavaScript Error: "Gloda is not defined" {file: "chrome://messenger/content/mailWindow.js" line: 363}]' when calling method: [nsIActivityMgrListener::onAddedActivity]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame :: file:///Applications/Thunderbird.app/Contents/MacOS/components/nsActivityManager.js :: anonymous :: line 115"  data: yes]
2010-07-06 00:48:30	nsActivityManager	ERROR	Exception calling onAddedActivity[Exception... "'[JavaScript Error: "Gloda is not defined" {file: "chrome://messenger/content/mailWindow.js" line: 363}]' when calling method: [nsIActivityMgrListener::onAddedActivity]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame :: file:///Applications/Thunderbird.app/Contents/MacOS/components/nsActivityManager.js :: anonymous :: line 115"  data: yes]
2010-07-06 00:48:32	nsActivityManager	ERROR	Exception calling onAddedActivity[Exception... "'[JavaScript Error: "Gloda is not defined" {file: "chrome://messenger/content/mailWindow.js" line: 363}]' when calling method: [nsIActivityMgrListener::onAddedActivity]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame :: file:///Applications/Thunderbird.app/Contents/MacOS/components/nsActivityManager.js :: anonymous :: line 115"  data: yes]
2010-07-06 00:49:01	nsActivityManager	ERROR	Exception calling onAddedActivity[Exception... "'[JavaScript Error: "Gloda is not defined" {file: "chrome://messenger/content/mailWindow.js" line: 363}]' when calling method: [nsIActivityMgrListener::onAddedActivity]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame :: file:///Applications/Thunderbird.app/Contents/MacOS/components/nsActivityManager.js :: anonymous :: line 115"  data: yes]
2010-07-06 00:49:01	nsActivityManager	ERROR	Exception calling onAddedActivity[Exception... "'[JavaScript Error: "Gloda is not defined" {file: "chrome://messenger/content/mailWindow.js" line: 363}]' when calling method: [nsIActivityMgrListener::onAddedActivity]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame :: file:///Applications/Thunderbird.app/Contents/MacOS/components/nsActivityManager.js :: anonymous :: line 115"  data: yes]
2010-07-06 00:49:14	nsActivityManager	ERROR	Exception calling onAddedActivity[Exception... "'[JavaScript Error: "Gloda is not defined" {file: "chrome://messenger/content/mailWindow.js" line: 363}]' when calling method: [nsIActivityMgrListener::onAddedActivity]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame :: file:///Applications/Thunderbird.app/Contents/MacOS/components/nsActivityManager.js :: anonymous :: line 115"  data: yes]
2010-07-06 00:49:14	nsActivityManager	ERROR	Exception calling onAddedActivity[Exception... "'[JavaScript Error: "Gloda is not defined" {file: "chrome://messenger/content/mailWindow.js" line: 363}]' when calling method: [nsIActivityMgrListener::onAddedActivity]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame :: file:///Applications/Thunderbird.app/Contents/MacOS/components/nsActivityManager.js :: anonymous :: line 115"  data: yes]
2010-07-06 00:49:31	nsActivityManager	ERROR	Exception calling onAddedActivity[Exception... "'[JavaScript Error: "Gloda is not defined" {file: "chrome://messenger/content/mailWindow.js" line: 363}]' when calling method: [nsIActivityMgrListener::onAddedActivity]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame :: file:///Applications/Thunderbird.app/Contents/MacOS/components/nsActivityManager.js :: anonymous :: line 115"  data: yes]
2010-07-06 00:49:31	nsActivityManager	ERROR	Exception calling onAddedActivity[Exception... "'[JavaScript Error: "Gloda is not defined" {file: "chrome://messenger/content/mailWindow.js" line: 363}]' when calling method: [nsIActivityMgrListener::onAddedActivity]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame :: file:///Applications/Thunderbird.app/Contents/MacOS/components/nsActivityManager.js :: anonymous :: line 115"  data: yes]
2010-07-06 00:50:29	nsActivityManager	ERROR	Exception calling onAddedActivity[Exception... "'[JavaScript Error: "Gloda is not defined" {file: "chrome://messenger/content/mailWindow.js" line: 363}]' when calling method: [nsIActivityMgrListener::onAddedActivity]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame :: file:///Applications/Thunderbird.app/Contents/MacOS/components/nsActivityManager.js :: anonymous :: line 115"  data: yes]
2010-07-06 00:50:29	nsActivityManager	ERROR	Exception calling onAddedActivity[Exception... "'[JavaScript Error: "Gloda is not defined" {file: "chrome://messenger/content/mailWindow.js" line: 363}]' when calling method: [nsIActivityMgrListener::onAddedActivity]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame :: file:///Applications/Thunderbird.app/Contents/MacOS/components/nsActivityManager.js :: anonymous :: line 115"  data: yes]
you see these console messages, but are you actually seeing any bad behavior in Thunderbird?
Summary: message from Thunderbird → "Gloda is not defined" error console message from Thunderbird
Olivier is gloda enabled on your installation of thunderbird ?
(In reply to comment #1)
> you see these console messages, but are you actually seeing any bad behavior in
> Thunderbird?

Just upgraded to 3.1 on ubuntu box.  It seems whenever I open a reply compose window the background color is a horrid bright green which isn't noted/called for anywhere.  I thought that this Gloda error might have been the cause but now, after clearing  error console and bringing up an offending reply screen, the error doesn't show so I must be off base.
But the Gloda error exists here for me - I have Gloda disabled.
I can confirm this, I also see from time to time the same message in the error console. But I have no STR. I've tried to trigger this message, but with no success. If I see this message, than TB is very slow-acting for a few minutes.
Today I've seen this message two times in the console with:

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b3pre) Gecko/20100804 Thunderbird/3.2a1pre

I have gloda enabled.
* bienvenu conversation with same error console at http://getsatisfaction.com/mozilla_messaging/topics/why_did_your_update_wipe_out_my_address_books#reply_3446772
* nomis at http://forums.mozillazine.org/viewtopic.php?p=9625841#p9625841
* http://forums.mozillazine.org/viewtopic.php?p=9769085#p9769085

I encountered this today - message preview pane got all funky and unable to consistently display messages. I had to restart

Bug 573376 - Copying/Moving a message in a separater window causes "Gloda not defined" error - also cites nsIActivityMgrListener::onAddedActivity
Right, so we probably want to import Gloda into the namespaces of the windows that have the activity manager in them or have the activity manager code check to see if Gloda is defined before attempting to subscript it.
crude modification
Blocks: 573376
Status: UNCONFIRMED → NEW
Component: General → Search
Ever confirmed: true
OS: Mac OS X → All
QA Contact: general → search
Summary: "Gloda is not defined" error console message from Thunderbird → ensure Gloda is in the namespaces of the windows that use Activity Manager - "Gloda is not defined" error console message from Thunderbird
Attached patch The fix (obsolete) — Splinter Review
The only place we use the activity manager is in mailWindow.js which is used in both the 3-pane window and the standalone window.

I'm guessing the 3-pane window gets gloda.js from elsewhere, but the standalone window isn't as complex so doesn't get it.

Therefore just get mailWindow.js to load gloda.js so that it always has it.
Assignee: nobody → bugzilla
Status: NEW → ASSIGNED
Attachment #487546 - Flags: review?(bugmail)
Component: Search → Message Reader UI
QA Contact: search → message-reader
No longer blocks: 573376
Duplicate of this bug: 573376
Comment on attachment 487546 [details] [diff] [review]
The fix

You actually want modules/gloda/public.js, not modules/gloda/gloda.js.
Attachment #487546 - Flags: review?(bugmail) → review+
Attached patch The fix v2Splinter Review
Updated patch with comment addressed.
Attachment #487546 - Attachment is obsolete: true
Checked into trunk: http://hg.mozilla.org/comm-central/rev/e68853832336
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.3a1
Comment on attachment 489140 [details] [diff] [review]
The fix v2

I'm thinking we should probably take this on 1.9.2 to stop people being confused by the error as we've seen it reported quite a bit.
Attachment #489140 - Flags: approval-thunderbird3.1.7?
Attachment #489140 - Flags: approval-thunderbird3.1.7? → approval-thunderbird3.1.7+
Thank for your message but how mus I fix it on Mac , I research with spotlight file mailWindow.js But i don't see this one . do you know the exact directory?
(In reply to comment #14)
> Thank for your message but how mus I fix it on Mac , I research with spotlight
> file mailWindow.js But i don't see this one . do you know the exact directory?

This error shouldn't actually hurt anything within Thunderbird, it is just noise on the console. If you don't know how to apply it, just wait until early-mid December which is our next planned release.
gone for me on trunk. I didn't test branch
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.