AIX compilation error in ipc/chromium/src/base/atomicops.h

RESOLVED WONTFIX

Status

()

Core
IPC
P5
normal
RESOLVED WONTFIX
8 years ago
8 months ago

People

(Reporter: ul, Assigned: Himanshu Sehgal)

Tracking

Trunk
PowerPC
AIX
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(4 attachments)

(Reporter)

Description

8 years ago
xlC_r -o nsXPComInit.o -c  -DMOZILLA_INTERNAL_API -D_IMPL_NS_COM -DEXPORT_XPT_API -DEXPORT_XPTC_API -D_IMPL_NS_COM_OBSOLETE -D_IMPL_NS_GFX -D_IMPL_NS_WIDGET -DIMPL_XREAPI -DIMPL_NS_NET -DIMPL_THEBES  -DOSTYPE=\"AIX5.2\" -DOSARCH=AIX -DEXCLUDE_SKIA_DEPENDENCIES -DCHROMIUM_MOZILLA_BUILD  -DOS_LINUX=1 -DOS_POSIX=1  -D_IMPL_NS_COM -D_IMPL_NS_STRINGAPI -DEXPORT_XPT_API -DEXPORT_XPTC_API -DTARGET_XPCOM_ABI=\"ppc-ibmc\" -I/home/ulink/src/mozilla-1.9.2/xpcom/build -I.. -I/home/ulink/src/mozilla-1.9.2/xpcom/build/../glue -I/home/ulink/src/mozilla-1.9.2/xpcom/build/../base -I/home/ulink/src/mozilla-1.9.2/xpcom/build/../ds -I/home/ulink/src/mozilla-1.9.2/xpcom/build/../io -I/home/ulink/src/mozilla-1.9.2/xpcom/build/../components -I/home/ulink/src/mozilla-1.9.2/xpcom/build/../threads -I/home/ulink/src/mozilla-1.9.2/xpcom/build/../threads/_xpidlgen -I/home/ulink/src/mozilla-1.9.2/xpcom/build/../proxy/src -I/home/ulink/src/mozilla-1.9.2/xpcom/build/../reflect/xptinfo/src  -I/home/ulink/src/mozilla-1.9.2/ipc/chromium/src -I/home/ulink/src/mozilla-1.9.2/ipc/glue -I../../ipc/ipdl/_ipdlheaders  -I/home/ulink/src/mozilla-1.9.2/xpcom/build -I. -I../../dist/include -I../../dist/include/nsprpub  -I/home/ulink/src/mozilla-1.9.2/obj-fx36-aix52/dist/include/nspr -I/home/ulink/src/mozilla-1.9.2/obj-fx36-aix52/dist/include/nss        -qflag=w:w   -DNDEBUG -DTRIMMED -I/opt/freeware/include/gtk-2.0 -I/opt/freeware/lib/gtk-2.0/include -I/opt/freeware/include/atk-1.0 -I/opt/freeware/include/cairo -I/opt/freeware/include/pango-1.0 -I/opt/freeware/include/glib-2.0 -I/opt/freeware/lib/glib-2.0/include -I/opt/freeware/include/gtk-unix-print-2.0   -O   -DMOZILLA_VERSION=\"1.9.2.7\" -DMOZILLA_VERSION_U=1.9.2.7 -DAIX=1 -DHAVE_SYS_INTTYPES_H=1 -DNSCAP_DISABLE_DEBUG_PTR_TYPES=1 -DD_INO=d_ino -DSTDC_HEADERS=1 -DHAVE_ST_BLKSIZE=1 -DHAVE_SIGINFO_T=1 -DHAVE_INT16_T=1 -DHAVE_INT32_T=1 -DHAVE_INT64_T=1 -DHAVE_INT64=1 -DHAVE_UINT=1 -DHAVE_UINT_T=1 -DHAVE_UINT16_T=1 -DHAVE_DIRENT_H=1 -DHAVE_MEMORY_H=1 -DHAVE_UNISTD_H=1 -DHAVE_NL_TYPES_H=1 -DHAVE_MALLOC_H=1 -DHAVE_X11_XKBLIB_H=1 -DHAVE_SYS_STATVFS_H=1 -DHAVE_SYS_STATFS_H=1 -DHAVE_LIBC_R=1 -DHAVE_LIBM=1 -DHAVE_LIBDL=1 -DHAVE_LIBC_R=1 -DFUNCPROTO=15 -DHAVE_XSHM=1 -DHAVE_FT_BITMAP_SIZE_Y_PPEM=1 -DHAVE_FT_GLYPHSLOT_EMBOLDEN=1 -DHAVE_FT_LOAD_SFNT_TABLE=1 -DHAVE_FT_SELECT_SIZE=1 -D_REENTRANT=1 -DHAVE_RANDOM=1 -DHAVE_STRERROR=1 -DHAVE_LCHOWN=1 -DHAVE_FCHMOD=1 -DHAVE_SNPRINTF=1 -DHAVE_MEMMOVE=1 -DHAVE_RINT=1 -DHAVE_STAT64=1 -DHAVE_LSTAT64=1 -DHAVE_TRUNCATE64=1 -DHAVE_SETBUF=1 -DHAVE_ISATTY=1 -DHAVE_FLOCKFILE=1 -DHAVE_LOCALTIME_R=1 -DHAVE_STRTOK_R=1 -DHAVE_RES_NINIT=1 -DHAVE_LANGINFO_CODESET=1 -DVA_COPY=va_copy -DHAVE_VA_COPY=1 -DHAVE_I18N_LC_MESSAGES=1 -DMOZ_EMBEDDING_LEVEL_DEFAULT=1 -DMOZ_EMBEDDING_LEVEL_BASIC=1 -DMOZ_EMBEDDING_LEVEL_MINIMAL=1 -DMOZ_PHOENIX=1 -DMOZ_BUILD_APP=browser -DMOZ_DEFAULT_TOOLKIT=\"cairo-gtk2\" -DMOZ_X11=1 -DMOZ_WIDGET_GTK2=1 -DMOZ_ENABLE_XREMOTE=1 -DMOZ_OFFICIAL_BRANDING=1 -DMOZ_DISTRIBUTION_ID=\"org.mozilla\" -DMOZ_PANGO=1 -DMOZ_IPC=1 -DIBMBIDI=1 -DMOZ_VIEW_SOURCE=1 -DMOZ_XPINSTALL=1 -DMOZ_JSLOADER=1 -DNS_PRINTING=1 -DNS_PRINT_PREVIEW=1 -DMOZ_NO_XPCOM_OBSOLETE=1 -DMOZ_OGG=1 -DMOZ_WAVE=1 -DMOZ_SYDNEYAUDIO=1 -DMOZ_MEDIA=1 -DMOZ_XTF=1 -DMOZ_CRASHREPORTER_ENABLE_PERCENT=100 -DMOZ_MATHML=1 -DMOZ_ENABLE_CANVAS=1 -DMOZ_SVG=1 -DMOZ_UPDATE_CHANNEL=default -DMOZ_PLACES=1 -DMOZ_FEEDS=1 -DMOZ_STORAGE=1 -DMOZ_SAFE_BROWSING=1 -DMOZ_URL_CLASSIFIER=1 -DMOZ_LOGGING=1 -DMOZ_USER_DIR=\".mozilla\" -DMOZ_ENABLE_LIBXUL=1 -DHAVE_STDINT_H=1 -DHAVE_INTTYPES_H=1 -DMOZ_XUL=1 -DMOZ_PROFILELOCKING=1 -DMOZ_RDF=1 -DBUILD_CTYPES=1 -DMOZ_MORKREADER=1 -DMOZ_DLL_SUFFIX=\".so\" -DHAVE_FONTCONFIG_FCFREETYPE_H=1 -DXP_UNIX=1 -DUNIX_ASYNC_DNS=1  -D_MOZILLA_CONFIG_H_ -DMOZILLA_CLIENT /home/ulink/src/mozilla-1.9.2/xpcom/build/nsXPComInit.cpp
"/home/ulink/src/mozilla-1.9.2/ipc/chromium/src/base/atomicops.h", line 136.2: 1540-0859 (S) #error directive: "Atomic operations are not supported on your platform".
"/home/ulink/src/mozilla-1.9.2/ipc/chromium/src/base/port.h", line 60.6: 1540-0859 (S) #error directive: No va_copy for your compiler.
"/home/ulink/src/mozilla-1.9.2/ipc/chromium/src/build/build_config.h", line 25.2: 1540-0859 (S) #error directive: Please add support for your platform in build/build_config.h.
"/home/ulink/src/mozilla-1.9.2/ipc/chromium/src/build/build_config.h", line 40.2: 1540-0859 (S) #error directive: Please add support for your compiler in build/build_config.h.
"/home/ulink/src/mozilla-1.9.2/ipc/chromium/src/build/build_config.h", line 61.2: 1540-0859 (S) #error directive: Please add support for your architecture in build/build_config.h.
gmake[5]: *** [nsXPComInit.o] Error 1
gmake[5]: Leaving directory `/home/ulink/src/mozilla-1.9.2/obj-fx36-aix52/xpcom/build'
gmake[4]: *** [libs] Error 2
gmake[4]: Leaving directory `/home/ulink/src/mozilla-1.9.2/obj-fx36-aix52/xpcom'
gmake[3]: *** [libs_tier_xpcom] Error 2
gmake[3]: Leaving directory `/home/ulink/src/mozilla-1.9.2/obj-fx36-aix52'
gmake[2]: *** [tier_xpcom] Error 2
gmake[2]: Leaving directory `/home/ulink/src/mozilla-1.9.2/obj-fx36-aix52'
gmake[1]: *** [default] Error 2
gmake[1]: Leaving directory `/home/ulink/src/mozilla-1.9.2/obj-fx36-aix52'
gmake: *** [build] Error 2
bash-3.2$
(Reporter)

Comment 1

8 years ago
What is the status for Solaris/SPARC ?
I don't see much except x86/GCC in chromium.
(Reporter)

Updated

8 years ago
Component: XPCOM → IPC
QA Contact: xpcom → ipc

Comment 2

8 years ago
We have patches to make it compile with Sun Studio on x86 and SPARC.
(ipdl-tests passed on both x86 and SPARC, however, plugin container doesn't work correctly on SPARC. I'm going to fix it)

The patch was not submitted to b.m.o. yet, still needs some polishing.
I'm going to do so in this month.

Meanwhile, you can compile Firefox with disable-ipc.
(Reporter)

Comment 3

8 years ago
(In reply to comment #2)
> We have patches to make it compile with Sun Studio on x86 and SPARC.
> (ipdl-tests passed on both x86 and SPARC, however, plugin container doesn't
> work correctly on SPARC. I'm going to fix it)
> 
> The patch was not submitted to b.m.o. yet, still needs some polishing.
> I'm going to do so in this month.

plz cc me on the forthcoming SPARC/SunStudio porting bugs.
Peeking at the Solaris port helped me quite a lot in the past.

> Meanwhile, you can compile Firefox with disable-ipc.

There were only two plugins on AIX: OJI Java plugin and a 32bit only AcrobatReader plugin. Without OJI since 1.9.2 there is not much left I would loose without --disable-ipc and out of process plugins on AIX.
(Reporter)

Updated

8 years ago
Blocks: 618660

Comment 4

7 years ago
--disable-ipc isn't working for firefox-6.0 anymore?
Support for --disable-ipc was removed.
(Assignee)

Comment 6

6 years ago
When can we expect --disable-ipc to be re introduced with Firefox.

 Without this we cannot complete Firefox-6 and above builds on AIX. Seems minimal  ppc support for ipc but AIX support is completely missing for ipc (no support for AIX even with gcc). We used to build Firefox on AIX earlier with --disable-ipc but now we cannot go any further than ipc.

Please suggest some way forward.
(Reporter)

Comment 7

6 years ago
(In reply to Himanshu Sehgal from comment #6)
> When can we expect --disable-ipc to be re introduced with Firefox.
> 

Don't expect it.

>  Without this we cannot complete Firefox-6 and above builds on AIX. Seems
> minimal  ppc support for ipc but AIX support is completely missing for ipc
> (no support for AIX even with gcc). We used to build Firefox on AIX earlier
> with --disable-ipc but now we cannot go any further than ipc.
> 
> Please suggest some way forward.

You'll need to port the chromium lib to AIX.

If you use GCC you can much more easily reuse bits from MacOSX/PPC. Take a look at what the TenFourFox guys have done.

If you can and will share your local patches, I can and will help you with testing and reviewing and maybe I would do 32bit port.

Firefox 10 would be a stable source base for at least one more year.
(Reporter)

Updated

6 years ago
Assignee: nobody → sehgal.himanshu01
Version: 1.9.2 Branch → Trunk
(Reporter)

Updated

6 years ago
No longer blocks: 618660
(Assignee)

Comment 8

6 years ago
I am submitting my changes for the chromium port for Firefox 64bit on AIX. The changes are compiled by gcc 4.6.1 .

Please review the changes.
(Assignee)

Comment 9

6 years ago
Created attachment 644233 [details] [diff] [review]
Chromium library changes for AIX

Chromium library changes for AIX
(Assignee)

Comment 10

6 years ago
Created attachment 644234 [details]
Atomic ops changes extended for 64bit AIX

New file with added changes for 64bit Atomic ops
(Assignee)

Comment 11

6 years ago
Created attachment 644235 [details]
New File
(Assignee)

Comment 12

6 years ago
Created attachment 644237 [details]
New File
(Assignee)

Comment 13

6 years ago
most of the code has been used from the Linux counterpart with additional changes required for AIX.

Used attachments from defect #579757 for atomic ops in ppc 32bit for chromium and have extended 64bit PPC support in the file.
Attachment #644233 - Flags: review?(jones.chris.g)
Attachment #644234 - Flags: review?(jones.chris.g)
Attachment #644235 - Flags: review?(jones.chris.g)
Attachment #644237 - Flags: review?(jones.chris.g)
Comment on attachment 644233 [details] [diff] [review]
Chromium library changes for AIX

Please attach the output of |hg diff| or |hg export|.
Attachment #644233 - Flags: review?(jones.chris.g)
Comment on attachment 644234 [details]
Atomic ops changes extended for 64bit AIX

For these too.
Attachment #644234 - Flags: review?(jones.chris.g)
(Assignee)

Comment 16

6 years ago
I do not have access to the AIX box now, thus would not be able to provide you the hg diff .
See Also: → bug 1250996

Updated

8 months ago
Priority: -- → P5

Updated

8 months ago
Status: NEW → RESOLVED
Last Resolved: 8 months ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.