577153 - comment out all locales other than en-US for LATEST_DEVEL_VERSION in firefoxDetailsClass.php

Status: RESOLVED FIXED

(www.mozilla.org :: General, defect)

Description

[Mike Beltzner [:beltzner, not reading bugmail]]

Attachment: patch commenting out all the locales other than en-US

Patch attached, I just can't seem to apply it!

Comment 1

[Michael Morgan [:morgamic]]

Checked it into trunk so we can test.

[morgamic@khan product-details]$ svn ci
Sending        firefoxDetails.class.php
Transmitting file data .
Committed revision 70172.

Comment 2

[Mike Beltzner [:beltzner, not reading bugmail]]

That still left a few - maybe the beta locales?

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Yeah, need to do this for $beta_builds too.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Attachment: additional changes

Ignore that last comment, we just missed some.

Comment 5

[Michael Morgan [:morgamic]]

[morgamic@khan product-details]$ svn ci firefoxDetails.class.php 
Sending        firefoxDetails.class.php
Transmitting file data .
Committed revision 70174.

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Still some left http://grab.by/5iql

Comment 7

[:Gavin Sharp [email: [e-mail]]]

The last checkin hasn't taken effect yet, for some reason.

Comment 8

[:Gavin Sharp [email: [e-mail]]]

<buchanan> gavin: fwiw, i can see the change working on my dev instance, http://ab-trunk.khan.mozilla.org/en-US/firefox/all-beta.html

So seems like it's just some slowness with trunk-stage. Can we update svn:externals on tags/stage and test there? Or just push to production? Pretty simple change...

Comment 9

[:Gavin Sharp [email: [e-mail]]]

OK, it's updated on trunk now:
https://www-trunk.stage.mozilla.com/en-US/firefox/all-beta.html

Can we update svn:externals on production?

Comment 10

[Alex Buchanan [:abuchanan]]

updated to p-d revision# 70174 in prod/stage

Comment 11

[Kohei Yoshino]

Is there any problem on non en-US builds? Or are we just second-class citizens?

Comment 12

[Mike Beltzner [:beltzner, not reading bugmail]]

(In reply to comment #11)
> Is there any problem on non en-US builds? Or are we just second-class citizens?

We don't have non en-US builds for Firefox 4 beta 1. You are not second class citizens, but before this fix, we were falsely presenting en-US builds as xx-XX builds.

Comment 13

[Mark Banner (:standard8)]

php export_json.php wasn't run when this was checked in - so json/firefox_primary_builds.json is now out of date.

I don't know if anyone uses that, but I was told that we should be keeping the json in sync with the php classes.

Comment 14

[Pascal Chevrel:pascalc]

json feed updated in r70452