comment out all locales other than en-US for LATEST_DEVEL_VERSION in firefoxDetailsClass.php

RESOLVED FIXED

Status

www.mozilla.org
General
RESOLVED FIXED
8 years ago
6 years ago

People

(Reporter: beltzner, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

Created attachment 456198 [details] [diff] [review]
patch commenting out all the locales other than en-US

Patch attached, I just can't seem to apply it!
Checked it into trunk so we can test.

[morgamic@khan product-details]$ svn ci
Sending        firefoxDetails.class.php
Transmitting file data .
Committed revision 70172.
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
That still left a few - maybe the beta locales?
Yeah, need to do this for $beta_builds too.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Created attachment 456200 [details] [diff] [review]
additional changes

Ignore that last comment, we just missed some.
[morgamic@khan product-details]$ svn ci firefoxDetails.class.php 
Sending        firefoxDetails.class.php
Transmitting file data .
Committed revision 70174.
Status: REOPENED → RESOLVED
Last Resolved: 8 years ago8 years ago
Resolution: --- → FIXED
Still some left http://grab.by/5iql
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
The last checkin hasn't taken effect yet, for some reason.
<buchanan> gavin: fwiw, i can see the change working on my dev instance, http://ab-trunk.khan.mozilla.org/en-US/firefox/all-beta.html

So seems like it's just some slowness with trunk-stage. Can we update svn:externals on tags/stage and test there? Or just push to production? Pretty simple change...
OK, it's updated on trunk now:
https://www-trunk.stage.mozilla.com/en-US/firefox/all-beta.html

Can we update svn:externals on production?
updated to p-d revision# 70174 in prod/stage
Status: REOPENED → RESOLVED
Last Resolved: 8 years ago8 years ago
Resolution: --- → FIXED
Is there any problem on non en-US builds? Or are we just second-class citizens?
(In reply to comment #11)
> Is there any problem on non en-US builds? Or are we just second-class citizens?

We don't have non en-US builds for Firefox 4 beta 1. You are not second class citizens, but before this fix, we were falsely presenting en-US builds as xx-XX builds.
php export_json.php wasn't run when this was checked in - so json/firefox_primary_builds.json is now out of date.

I don't know if anyone uses that, but I was told that we should be keeping the json in sync with the php classes.
json feed updated in r70452
(Assignee)

Updated

6 years ago
Component: www.mozilla.org/firefox → www.mozilla.org
Product: Websites → Websites
(Assignee)

Updated

6 years ago
Component: www.mozilla.org → General
Product: Websites → www.mozilla.org
You need to log in before you can comment on or make changes to this bug.