577158 - Tab Candy prevents Feedback button from being seen

Status: RESOLVED WORKSFORME

(Firefox Graveyard :: Panorama, defect)

Description

[Laura Mesa [:lmesa] [:lvmesa]]

I just manually updated form F4 4 b1 build 1 to build 2 and I cannot see the feedback button.

I then uninstalled Firefox and installed from the firefox.com/beta page in my normal profile and the button was still missing. 

When I installed it on a fresh profile and removed my installed Test Pilot Add-On, however, it appears.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

So Laura had installed Test Pilot v1.0b4 from AMO in parallel which is not compatible with Firefox 4 Beta 1. Because of that the extension wasn't enabled. But even after removing the extension from the profile folder didn't show up the feedback button onto the toolbar. Only removing the prefs.js did the trick and the button re-appeared. I'm working on which specific entry is causing this issue.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

As testing has been shown at least for the profile from Laura, the reason why the reporter button isn't shown in the toolbar is the latest version of TabCandy. We have to check if others also have TabCandy installed.

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

I've seen this issue with the Tab Candy add-on, I think Aza knows about it, but if not, he will when he gets this bugmail!

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Ok, so after talking to different people who have seen this issue, we were able to get back the feedback button when TabCandy is disabled.

Beside that I'm also able to see the problem on Linux where TabCandy hasn't been installed. I will continue to work on that and file another bug with my findings.

Comment 5

[Ian Gilman [:iangilman]]

The latest version of TabCandy is no longer an add-on, but actually built into Firefox (in a separate branch for the time being). I believe this is not an issue in that version (due to how we add the TabCandy button there).

Comment 6

[Jono Xia]

Just in case it's relevant, here's the code in the Feedback extension that puts the button into the toolbar: http://hg.mozilla.org/labs/testpilot/file/a35ae871b895/extension/content/browser.js#l170

Comment 7

[Jono Xia]

See also bug https://bugzilla.mozilla.org/show_bug.cgi?id=578101 , which is for the case where the Feedback button disappears and it's NOT TabCandy's fault.

Comment 8

[Aza Raskin [:aza]]

This is a bug with the extension which we are no longer maintaining and has been fixed in the branch edition.

Comment 9

[Aza Raskin [:aza]]

@jono: P.S., there is an odd fragment in that code: '-1 == curSet.indexOf("feedback-menu-button")'

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to comment #8)
> This is a bug with the extension which we are no longer maintaining and has
> been fixed in the branch edition.

Well, then we should call it WFM. We will recheck once TabCandy has been landed on trunk.

Comment 11

[Jono Xia]

@Aza: Why is that fragment odd?  It's checking whether the feedback menu button is currently included in the toolbar or not; if it's not present indexOf() will return -1; the -1 is on the left of the comparison as standard defensive programming to make accidental assignment less likely.

Of course if indexOf is somehow returning a value other than -1 when the button is not present, then it won't add the button, so that could explain the problem...

Comment 12

[(no longer active)]

Mass moving all Tab Candy bugs from Mozilla Labs to Firefox::Tab Candy.  Filter the bugmail spam with "tabcandymassmove".