577220 - Problem when parsing Outlook "X-ALT-DESC" property

Reporter

Description

•

14 years ago

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; de; rv:1.9.1.10) Gecko/20100504 Firefox/3.5.10 ( .NET CLR 3.5.30729)
Build Identifier: Lightning 1.0b2

I create a iCal-File with Outlook. Then I edited this file with Mozilla Lightning. I could load this edited file with Outlook, but not with the Java-Libary "iCal4j".

After I examinated the edit file, i found some stange strange sysntax.

Original from Outlook:
---------------------------------------------------------------
X-ALT-DESC;FMTTYPE=text/html:<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//E
	N">\n<HTML>\n<HEAD>\n<META NAME="Generator" CONTENT="MS Exchange Server ve
	rsion 08.00.0681.000">\n<TITLE></TITLE>\n</HEAD>\n<BODY>\n<!-- Converted f
	rom text/rtf format -->\n\n<P DIR=LTR><SPAN LANG="de"><B><FONT FACE="Calib
	ri">Test</FONT></B></SPAN></P>\n\n<P DIR=LTR><SPAN LANG="de"><I><FONT FACE
	="Calibri">Cool</FONT></I></SPAN></P>\n\n</BODY>\n</HTML>
----------------------------------------------------
What Lightning has made of it:
-------------------------------------------
X-ALT-DESC;FMTTYPE=text/html:<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//
 EN">
<HTML>
<HEAD>
<META NAME="Generator" CONTENT="MS Exchange Server vers
 ion 08.00.0681.000">
<TITLE></TITLE>
</HEAD>
<BODY>
<!-- Converted from te
 xt/rtf format -->

<P DIR=LTR><SPAN LANG="de"><B><FONT FACE="Calibri">Test
 </FONT></B></SPAN></P>

<P DIR=LTR><SPAN LANG="de"><I><FONT FACE="Calibri"
 >Cool</FONT></I></SPAN></P>

</BODY>
</HTML>
--------------------------------------------
A I reopend Lightning and edited the file again, the property has changed to this:
---------------------------------------------
X-ALT-DESC;FMTTYPE=text/html:<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//
 EN">
X-LIC-ERROR;X-LIC-ERRORTYPE=COMPONENT-PARSE-ERROR:Got a data line\, but co
 uld not find a property name or component begin tag: </HTML>
-----------------------------------------------


Reproducible: Always

Steps to Reproduce:
1. Create a event in Outlook, with summary and an HTML description.
2. Export it to a iCal (*.ics)
3. Load it with Lightning (as network calendar, of automatic update of the file)
4. Edit the event
5. => The problem with the systax is now in the ics-file



Original-Outlook-File:
----------------------------------------------
BEGIN:VCALENDAR
PRODID:-//Microsoft Corporation//Outlook 12.0 MIMEDIR//EN
VERSION:2.0
METHOD:PUBLISH
X-CALSTART:20100707T080000Z
X-CALEND:20100707T082100Z
X-WR-RELCALID:{0000002E-FE58-BC54-1868-64E506A158B8}
X-WR-CALNAME:\\data\\cosmod_workspace_entwicklung\\mobikat start db alles\\
	veranstaltungen\\Test
BEGIN:VEVENT
CLASS:PUBLIC
CREATED:20100707T082456Z
DESCRIPTION:Test\nCool\n
DTEND:20100707T082100Z
DTSTAMP:20100707T082352Z
DTSTART:20100707T080000Z
LAST-MODIFIED:20100707T082521Z
LOCATION:Buehne2
PRIORITY:5
SEQUENCE:2
SUMMARY;LANGUAGE=de:B2: Aaaaaa
TRANSP:OPAQUE
UID:040000008200E00074C5B7101A82E00800000000A072EA71151DCB01000000000000000
	010000000279C12A8CCCE854DA7312CA0129E4174
X-ALT-DESC;FMTTYPE=text/html:<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//E
	N">\n<HTML>\n<HEAD>\n<META NAME="Generator" CONTENT="MS Exchange Server ve
	rsion 08.00.0681.000">\n<TITLE></TITLE>\n</HEAD>\n<BODY>\n<!-- Converted f
	rom text/rtf format -->\n\n<P DIR=LTR><SPAN LANG="de"><B><FONT FACE="Calib
	ri">Test</FONT></B></SPAN></P>\n\n<P DIR=LTR><SPAN LANG="de"><I><FONT FACE
	="Calibri">Cool</FONT></I></SPAN></P>\n\n</BODY>\n</HTML>
X-MICROSOFT-CDO-BUSYSTATUS:BUSY
X-MICROSOFT-CDO-IMPORTANCE:1
X-MICROSOFT-DISALLOW-COUNTER:FALSE
X-MS-OLK-ALLOWEXTERNCHECK:TRUE
X-MS-OLK-AUTOFILLLOCATION:FALSE
X-MS-OLK-CONFTYPE:0
END:VEVENT
END:VCALENDAR
------------------------------------------------------
File after first editing with Lightning :
-------------------------------------------------------
BEGIN:VCALENDAR
PRODID:-//Mozilla.org/NONSGML Mozilla Calendar V1.1//EN
VERSION:2.0
METHOD:PUBLISH
X-CALSTART:20100707T080000Z
X-CALEND:20100707T082100Z
X-WR-RELCALID:{0000002E-FE58-BC54-1868-64E506A158B8}
X-WR-CALNAME:\data\cosmod_workspace_entwicklung\mobikat start db alles\ver
 anstaltungen\Test
X-WR-TIMEZONE:Europe/Paris
BEGIN:VEVENT
CREATED:20100707T082456Z
LAST-MODIFIED:20100707T083323Z
DTSTAMP:20100707T083323Z
UID:040000008200E00074C5B7101A82E00800000000A072EA71151DCB0100000000000000
 0010000000279C12A8CCCE854DA7312CA0129E4174
SUMMARY:B2: Aaaaaa
PRIORITY:5
DTSTART:20100707T081500Z
DTEND:20100707T083600Z
CLASS:PUBLIC
DESCRIPTION:Test\nCool\n
LOCATION:Buehne2
SEQUENCE:3
TRANSP:OPAQUE
X-ALT-DESC;FMTTYPE=text/html:<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//
 EN">
<HTML>
<HEAD>
<META NAME="Generator" CONTENT="MS Exchange Server vers
 ion 08.00.0681.000">
<TITLE></TITLE>
</HEAD>
<BODY>
<!-- Converted from te
 xt/rtf format -->

<P DIR=LTR><SPAN LANG="de"><B><FONT FACE="Calibri">Test
 </FONT></B></SPAN></P>

<P DIR=LTR><SPAN LANG="de"><I><FONT FACE="Calibri"
 >Cool</FONT></I></SPAN></P>

</BODY>
</HTML>
X-MICROSOFT-CDO-BUSYSTATUS:BUSY
X-MICROSOFT-CDO-IMPORTANCE:1
X-MICROSOFT-DISALLOW-COUNTER:FALSE
X-MS-OLK-ALLOWEXTERNCHECK:TRUE
X-MS-OLK-AUTOFILLLOCATION:FALSE
X-MS-OLK-CONFTYPE:0
X-MOZ-GENERATION:1
END:VEVENT
END:VCALENDAR
----------------------------------------------------------------
Resart Lightning: File after seconde editing with Lightning:
----------------------------------------------------------------
BEGIN:VCALENDAR
PRODID:-//Mozilla.org/NONSGML Mozilla Calendar V1.1//EN
VERSION:2.0
METHOD:PUBLISH
X-CALSTART:20100707T080000Z
X-CALEND:20100707T082100Z
X-WR-RELCALID:{0000002E-FE58-BC54-1868-64E506A158B8}
X-WR-CALNAME:\data\cosmod_workspace_entwicklung\mobikat start db alles\ver
 anstaltungen\Test
X-WR-TIMEZONE:Europe/Paris
BEGIN:VEVENT
CREATED:20100707T082456Z
LAST-MODIFIED:20100707T085421Z
DTSTAMP:20100707T085421Z
UID:040000008200E00074C5B7101A82E00800000000A072EA71151DCB0100000000000000
 0010000000279C12A8CCCE854DA7312CA0129E4174
SUMMARY:B2: Aaaaaa
PRIORITY:5
DTSTART:20100707T080000Z
DTEND:20100707T082100Z
CLASS:PUBLIC
DESCRIPTION:Test\nCool\n
LOCATION:Buehne2
SEQUENCE:4
TRANSP:OPAQUE
X-ALT-DESC;FMTTYPE=text/html:<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//
 EN">
X-LIC-ERROR;X-LIC-ERRORTYPE=COMPONENT-PARSE-ERROR:Got a data line\, but co
 uld not find a property name or component begin tag: </HTML>
X-MICROSOFT-CDO-BUSYSTATUS:BUSY
X-MICROSOFT-CDO-IMPORTANCE:1
X-MICROSOFT-DISALLOW-COUNTER:FALSE
X-MS-OLK-ALLOWEXTERNCHECK:TRUE
X-MS-OLK-AUTOFILLLOCATION:FALSE
X-MS-OLK-CONFTYPE:0
X-MOZ-GENERATION:2
END:VEVENT
END:VCALENDAR

Simon Vaillancourt

Assignee

Comment 1

•

14 years ago

Confirmed, this bug causes serious interoperability issues with Outlook 2010

Status: UNCONFIRMED → NEW

Ever confirmed: true

Erwan MAS

Comment 2

•

14 years ago

for me it's similar with 536898 , please vote !

Bas van den Bosch

Updated

•

14 years ago

Flags: blocking-calendar1.0?

Erwan MAS

Comment 4

•

14 years ago

In bug 536898, we describe symptom related to CALDAV . It's important because many persons use CALDAV .

I use davmail , and my first idea was that caldav is bogus , but the developper says that is lightning .

The behavior in process is different for the fields DESCRIPTION and X-ALT-DESC .

"\n" in DESCRIPTION is correctely quoted instead X-ALT-DESC

Jdelic

Comment 5

•

14 years ago

I'm the original reporter of Bug 536898. I would like to point out that I wrote a Java servlet filter that fixes some of Lightning's CalDAV problems, which can be found here: http://maurus.net/resources/calendar-server-7/workaround-lightning-caldav/

This might serve as a temporary work-around for other people stumbling on this bug.

I'd also like to point you to: http://source.maurus.net/caldavfilter/file/1ff1c9624706/src/java/net/maurus/caldav/Bug536898Filter.java

I wrote that code 9 months ago, so I don't remember all the details, but it seems that the illegal use of double quotes in the HTML might lead to some of Lightning's behavior.

Erwan MAS

Comment 6

•

14 years ago

Bug is present in 1.0b3pre

Simon Vaillancourt

Assignee

Updated

•

14 years ago

Assignee: nobody → simon.at.orcl

Status: NEW → ASSIGNED

Simon Vaillancourt

Assignee

Comment 7

•

14 years ago

Attached patch libical decodes when reading x-prop values but does not re-encode when serializing, this patch should fix the issue — Details — Splinter Review

Attachment #496487 - Flags: review?(philipp)

Stefan Sitter [:ssitter]

Comment 8

•

14 years ago

Maybe it's time to check if we should upgrade libical to the latest release? Could be possible the issue has been fixed already in upstream version.

Simon Vaillancourt

Assignee

Comment 9

•

14 years ago

No it's not fixed in the latest libical release (unless I did not look at the right place..)  I filed them this bug:
https://sourceforge.net/tracker/?func=detail&atid=116077&aid=3133590&group_id=16077

Martin Schröder [:mschroeder]

Updated

•

14 years ago

OS: Windows Vista → All

Hardware: x86 → All

Philipp Kewisch [:Fallen] [:📆][:🧩]

Comment 10

•

14 years ago

Comment on attachment 496487 [details] [diff] [review]
libical decodes when reading x-prop values but does not re-encode when serializing, this patch should fix the issue

Lets give it a try, r=philipp and a=philipp for backport.

Attachment #496487 - Flags: review?(philipp) → review+

Philipp Kewisch [:Fallen] [:📆][:🧩]

Comment 11

•

14 years ago

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/180063a9fe4d>
-> FIXED

Status: ASSIGNED → RESOLVED

Closed: 14 years ago

Resolution: --- → FIXED

Target Milestone: --- → Trunk

Philipp Kewisch [:Fallen] [:📆][:🧩]

Comment 12

•

14 years ago

Backported to comm-1.9.2 <http://hg.mozilla.org/releases/comm-1.9.2/rev/dff93ddec45c>
a=philipp

Target Milestone: Trunk → 1.0b3

Martin Schröder [:mschroeder]

Updated

•

13 years ago

Flags: blocking-calendar1.0?

Allen Winter

Comment 13

•

13 years ago

To close the loop on this one, I want to report that I committed Simon's patch to the official libical source with revision r1063.  Should be included then in the next libical release (probably v0.47).

thanks for the patch.

Philipp Kewisch [:Fallen] [:📆][:🧩]

Comment 14

•

13 years ago

Thanks for taking care, Allen!

Bugzilla

Quick Search

Problem when parsing Outlook "X-ALT-DESC" property

Categories

(Calendar :: Import and Export, defect)

Tracking

(Not tracked)

People

(Reporter: marcel.heckel, Assigned: nomisvai)

References

Details

Crash Data

Security

(public)

User Story

Attachments

(1 file)

Description

Comment 1

Comment 2

Updated

Comment 4

Comment 5

Comment 6

Updated

Comment 7

Comment 8

Comment 9

Updated

Comment 10

Comment 11

Comment 12

Updated

Comment 13

Comment 14

Attachment

General

Description

File Name

Content Type