Closed
Bug 577237
Opened 14 years ago
Closed 14 years ago
LaunchChildMac - [NSString stringWithCString] is deprecated
Categories
(Toolkit Graveyard :: XULRunner, defect)
Tracking
(Not tracked)
RESOLVED
WORKSFORME
People
(Reporter: timeless, Assigned: timeless)
References
Details
Attachments
(2 files)
|
779 bytes,
patch
|
ted
:
review-
|
Details | Diff | Splinter Review |
|
987 bytes,
patch
|
Details | Diff | Splinter Review |
bug 577213 bumps the required version for the updater to 10.5 http://developer.apple.com/mac/library/documentation/Cocoa/Reference/Foundation/Classes/NSString_Class/Reference/NSString.html#//apple_ref/occ/clm/NSString/stringWithCString:encoding: requires 10.4 toolkit/xre/MacLaunchHelper.mm: In function ‘void LaunchChild(int, char**)’: 86: warning: ‘stringWithCString:’ is deprecated (declared at /System/Library/Frameworks/Foundation.framework/Headers/NSString.h:386)
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #456255 -
Flags: review?(ted.mielczarek)
|
||
Comment 2•14 years ago
|
||
Comment on attachment 456255 [details] [diff] [review] proposal It looks like you want to use [NSString defaultCStringEncoding], not NSASCIIStringEncoding: http://developer.apple.com/mac/library/documentation/Cocoa/Reference/Foundation/Classes/NSString_Class/Reference/NSString.html#//apple_ref/doc/uid/20000154-defaultCStringEncoding
Attachment #456255 -
Flags: review?(ted.mielczarek) → review-
actually, i wonder if i'm supposed to assume file system encoding.
|
||
Updated•14 years ago
|
OS: Mac OS X → Windows 7
|
||
Updated•14 years ago
|
OS: Windows 7 → Mac OS X
i think bug 600411 fixed this
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → WORKSFORME
|
||
Updated•8 years ago
|
Product: Toolkit → Toolkit Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•