577306 - For disabling options, should only look at the parent optgroup

Status: RESOLVED INVALID

(Core :: DOM: Core & HTML, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

In the testcase at <http://software.hixie.ch/utilities/js/live-dom-viewer/saved/538>, both options should be enabled, as the disabled optgroup is its parent, but rather a grandparent. See <http://www.whatwg.org/html/#concept-option-disabled>.

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: WIP

Still need to find a way to test this.

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Attachment: testcase

So do you know why html5 defines that behavior.
IMO, it makes more sense to disable everything under a disabled optgroup.

And the patch doesn't seem to work too well with this testcase.
The second option isn't gray'ed out, but user can't select it anyway.

Comment 4

[Mounir Lamouri (:mounir)]

We could use the patch in bug 759666 and directly use HasState() on the option element?

Comment 5

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

I think this is INVALID, because the spec says <option>s that aren't children of the <select> or of <optgroup> children of the <select> are not part of the list of options to start with (bug 1214164).

Comment 6

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

I'm not working on this bug.