577387 - remove iQ.each

Status: RESOLVED FIXED

(Firefox Graveyard :: Panorama, defect)

Description

[Michael Yoshitaka Erlewine [:mitcho]]

iQ.each is unnecessary and should be removed, and all uses of it should be rewritten using Array.forEach().

For why we are not using { for each (... in ...) } notation, see https://developer.mozilla.org/en/Core_JavaScript_1.5_Reference/Statements/for...in#Description

Comment 1

[Ed Lee :Mardak]

Just making sure, when you say Array.forEach, you actually mean [].forEach, yeah? Or is this for node lists and such, so you'll need to Array.forEach(list, callback) ?

Comment 2

[Michael Yoshitaka Erlewine [:mitcho]]

(In reply to comment #1)
> Just making sure, when you say Array.forEach, you actually mean [].forEach,
> yeah? Or is this for node lists and such, so you'll need to Array.forEach(list,
> callback) ?

Sorry, I did just mean [].forEach . Thanks!

Comment 3

[Aza Raskin [:aza]]

At the very least, for now we should add a log message at the top of iQ.each that prints out a deprecation warning.

Comment 4

[Michael Yoshitaka Erlewine [:mitcho]]

FYI: I did a lot of work along these lines today (on .each as well as other methods):

http://hg.mozilla.org/users/edward.lee_engineering.uiuc.edu/tabcandy-central/rev/5d8193161059

Comment 5

[Michael Yoshitaka Erlewine [:mitcho]]

Done!

http://hg.mozilla.org/users/edward.lee_engineering.uiuc.edu/tabcandy-central/rev/f20e74f100b6

Comment 6

[Ed Lee :Mardak]

FYI, forEach and most other array comprehension functions (except reduce) take a second argument for passing in "this".

Comment 7

[(no longer active)]

Mass moving all Tab Candy bugs from Mozilla Labs to Firefox::Tab Candy.  Filter the bugmail spam with "tabcandymassmove".