Closed
Bug 577535
Opened 14 years ago
Closed 14 years ago
Check the out params of GetFormInfoForInput before using them
Categories
(Camino Graveyard :: OS Integration, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: stuart.morgan+bugzilla, Assigned: stuart.morgan+bugzilla)
Details
(Whiteboard: [camino-2.0.4])
Attachments
(1 file)
|
3.65 KB,
patch
|
mikepinkerton
:
superreview+
|
Details | Diff | Splinter Review |
If GetFormInfoForInput in KeychainAutoCompleteSession.mm gives back a nil host, we push on with with a lookup that's not restricted by host, instead of bailing. In conjunction with the ASCII host fixup code, that can nuke keychain entries :( We need to check that we have a non-nil host. We also should just stop doing the fixup, since 1.6 and 2.0 have both had the fix.
|
Assignee | |
Updated•14 years ago
|
Assignee: nobody → stuart.morgan+bugzilla
Status: NEW → ASSIGNED
We'll want the safety part for 2.0.4.
Flags: camino2.0.4+
|
|
Assignee | |
Comment 2•14 years ago
|
||
Filed bug 577544 for the code remove since there's actually no good reason to lump them together. This is now just the safety part.
|
|
Assignee | |
Updated•14 years ago
|
Summary: Check out params of GetFormInfoForInput before using them → Check the out params of GetFormInfoForInput before using them
|
|
Assignee | |
Comment 3•14 years ago
|
||
Attachment #456520 -
Flags: superreview?(mikepinkerton)
(Per bug 577544 comment 1, this is now a 2.0-branch-specific patch.)
Version: Trunk → 1.9.0 Branch
|
||
Comment 5•14 years ago
|
||
Comment on attachment 456520 [details] [diff] [review] fix sr=pink
Attachment #456520 -
Flags: superreview?(mikepinkerton) → superreview+
Landed on CAMINO_2_0_BRANCH for Stuart in advance of 2.0.4.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Whiteboard: [camino-2.0.4]
You need to log in
before you can comment on or make changes to this bug.
Description
•