Make a new address book card, enter the person's details, and enter a URL. Commit the changes. Now click on that new card so that it loads in the address window. Click on the URL. Note that the URL loads in the address book window, replacing all the chrome in that window. The menus (on Mac) also become totally messed up. The only way out is to close the address book window.
Seems pretty serious; nominate for rtm.
We don't get the menus problem on Windows. Instead, all of the chrome for the AB disappears. I agree that this is lame, but I don't think this feature is high enough priority to warrant fixing for rtm. marking [rtm-]
Couldn't you just add a target="_blank" attribute to both the cvHomeWebPage and cvWorkWebPage elements ?? That will launch a new browser window.
reassigning to chuang
Linux (2001-03-13-08 mtrunk) Win32 (2001-03-13-10 mtrunk) Mac (2001-03-12-11 mtrunk) Re-test this bug and find no problem in these builds. Mark it worksforme
Unsure why this bug was marked as verified since this problem still exists in the Mozilla 0.9.3 baseline. Clicking on the web page link replaces the address book window with the website with NO controls. This problem can be fixed by adding a target="_blank" attribute to both the cvHomeWebPage and cvWorkWebPage. Please reopen this bug.
This is still happening.
To default owner.
Candice is no longer here.
reassigning to racham
*** Bug 72212 has been marked as a duplicate of this bug. ***
*** Bug 97296 has been marked as a duplicate of this bug. ***
Created attachment 53624 [details] [diff] [review] Modified mailnews\addrbook\resources\content\abCardViewOverlay.xul
With above changes, when user clicks on a url in the Address Book Card Viewer window, a new browser window will open with that url.
Do we always want a new window, or should it use the frontmost existing browser window if one exists?
Jessica, thanks for tackling this one also. cc'ing sspitzer. I think it should use the frontmost browser window like we do for clicking on a link in a mail window. Jennifer, any opinion?
The behavior should be the same as when clicking on a link in the mail window.
Created attachment 54233 [details] [diff] [review] modified abCardViewOverlay.js/xul to where clicking on url will open link in existing browser
Above patch includes fixes for bugs 92168 and 72213. User can now view email addresses and urls as links, click on an email address and a compose message window will come up, and click on a url and the page will come up in top browser window or open new browser window if one is not already open.
here's an updated patch, based on jessica's original patch. one problem with the original patch was that when mousing over the web page links, the mouse would not change (indicating it was a link). so, I copied her trick putting a box around the <a> node. but if you use href, we open in the ab window. if we do target="new", we'll always open in a new window, not the top most. I use onclick="return openLink()" and always return false from openLink() so that we don't do the href.
credit to jessica, for the original patch.
other difference between the last patch and the original patch is that if the html links are not visible, I don't do the , if the html links are not visible, I don't do the setAttribute().
Created attachment 55426 [details] [diff] [review] more cleanup of the patch, new function, HandleLink() does all the work.
fixed. thanks for the patch, jessica.
Trunk build 2001-11-13-03: WinMe Trunk build 2001-11-09: Linux RH 7.1, Mac 9.1 Verified Fixed, it now opens a browser window displaying the page.
whoops, the home page link is not blue, like the other links. I've logged another bug for that, fix in hand.