57759 - Items in xul textfield context menus need to enable/disable at proper times

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect, P3)

Description

[Blake Ross]

Undo needs to be enabled when there's nothing to be undone in the new xul 
textfield context menus (trunk only).

Comment 1

[Blake Ross]

Actually, all of the items (except Select All) need to be enabled/disabled at 
the right moments.

Comment 2

[Peter Trudelle]

->future

Comment 3

[Peter Trudelle]

->untargetted. cc pink & saari.  who should get this?

Comment 4

[Mike Pinkerton (not reading bugmail)]

MHO is that this is ender's bug, not a toolkit bug, as it deals with content of
the menus, not the menus. right?

all that's needed is an oncreate handler like in navigator.

Comment 5

[Peter Trudelle]

Okay, didn't know if there was one and it was just not working. Thanks! ->editor

Comment 6

[Blake Ross]

oh, I'll do it you big baby ;) (er, pink that is).

Comment 7

[Blake Ross]

*** Bug 64200 has been marked as a duplicate of this bug. ***

Comment 8

[timeless]

if i ever get focused i might look at this again.

Comment 9

[Blake Ross]

Attachment: [patch] disable when necessary...

Comment 10

[Kathleen :Brade]

what about redo and delete commands?  Should those be handled too?

Comment 11

[Blake Ross]

Ack...nice catch.  Apparently whoever implemented these textfields originally 
mistakenly used cmd_cut instead of cmd_delete when getting the controller, and 
I just looked down the list when writing the array.  I didn't catch this when 
testing because Delete and Cut are enabled/disabled at the same time.

Note also that for now we don't try to enable/disable Select All, because it 
never disables (there's another bug on disabling Select All when all the text 
is selected).

We have a separate bug on whether or not to add Redo.

brade, wanna review this?

Comment 12

[Blake Ross]

Attachment: [patch] fix delete

Comment 13

[Kathleen :Brade]

sidenote:  select all should also be disabled if there is no text

Comment 14

[Blake Ross]

Attachment: [patch] simplified

Comment 15

[Blake Ross]

Attachment: [patch] and now, the whole patch...(i'm an idiot)

Comment 16

[timeless]

while you're making major changes, could you aim for 80-82 columns?

Comment 17

[timeless]

r=timeless given assurance that the committed version addresses my concern.

Comment 18

[Blake Ross]

cc'ing alec for sr

Comment 19

[Alec Flett]

looks good blake... thanks for cleaning it up
sr=alecf

Comment 20

[Blake Ross]

checked in.

Comment 21

[Kathleen :Brade]

*** Bug 63693 has been marked as a duplicate of this bug. ***

Comment 22

[sujay]

verified in 2/6 build.