577602 - [PostgreSQL] Can't use multi-selects as buglist columns

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, defect)

Description

[Max Kanat-Alexander]

Trying to use a custom multi-select as a buglist column fails on PostgreSQL with the error:

  ERROR:  aggregates not allowed in GROUP BY clause
  LINE 1: ...bugs.bug_id AS bug_id, array_to_string(array_sort(array_accu...

Comment 1

[Max Kanat-Alexander]

Attachment: v1

This fixes it and is verified as working by xt/search.t. Those columns shouldn't have been in the GROUP BY on any platform--I guess MySQL just wasn't complaining for some reason.

It will require a very minor backportt for 3.6 ("keywords" does in fact belong in GROUP BY in 3.6).

Comment 2

[Max Kanat-Alexander]

Attachment: v1 (4.0)

Actually, turns out it requires a backport for 4.0 and 3.6 both, because 4.2 has $multi_select_fields where 4.0 has @multi_select_fields.

Comment 3

[Max Kanat-Alexander]

Attachment: v1 (3.6)

And in 3.6, the "keywords" field still needs to be in GROUP BY.

Comment 4

[Max Kanat-Alexander]

  I went ahead and checked this in on trunk, since xt/search.t shows it's working just fine and I have ownership on trunk. (And I want to continue with any other required search.t fixes, but I can't until this is checked in.) 

  However, the branch backports still need review.

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/
modified Bugzilla/Search.pm
Committed revision 7322.

Comment 5

[Frédéric Buclin]

Comment on attachment 456661 [details] [diff] [review]
v1 (4.0)

r=LpSolit

Comment 6

[Frédéric Buclin]

Comment on attachment 456662 [details] [diff] [review]
v1 (3.6)

Custom multi-select fields are not allowed in buglists in 3.6.

Comment 7

[Max Kanat-Alexander]

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/4.0/
modified Bugzilla/Search.pm
Committed revision 7314.