Closed
Bug 577609
Opened 14 years ago
Closed 14 years ago
nsIEditor.idl typedef's EDirection twice
Categories
(Core :: DOM: Editor, defect)
Core
DOM: Editor
Tracking
()
RESOLVED
FIXED
People
(Reporter: dholbert, Assigned: dholbert)
Details
Attachments
(1 file)
|
741 bytes,
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
Just noticed that nsIEditor.idl includes two typedefs for EDirection -- one inside of the nsIEditor class, and one outside. CVS blame says it's been that way since this file was initially added. Attached patch removes the outside-the-class typedef. Builds fine on my machine.
|
Assignee | |
Updated•14 years ago
|
Attachment #456533 -
Attachment is patch: true
Attachment #456533 -
Attachment mime type: application/octet-stream → text/plain
Attachment #456533 -
Flags: review?(neil)
|
||
Updated•14 years ago
|
Attachment #456533 -
Flags: review?(neil) → review+
|
|
||
Updated•14 years ago
|
Assignee: nobody → dholbert
|
|
Assignee | |
Comment 1•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/7ea7578d1af7
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
||
Comment 2•14 years ago
|
||
(Why did that need a uuid change?)
|
|
Assignee | |
Comment 3•14 years ago
|
||
Was pretty sure it didn't, but did it anyway just in case. (forgot whether UUID-revving was for changes to the file vs. changes to the class) Should I revert the UUID change?
|
|
||
Comment 4•14 years ago
|
||
(In reply to comment #3) > Was pretty sure it didn't, but did it anyway just in case. (forgot whether > UUID-revving was for changes to the file vs. changes to the class) > > Should I revert the UUID change? Technically, UUID changes matter only when the layout of the vtable for the interface changes. This patch did not produce such a change, but I r+'ed it for the cleanliness sake. I'd say it's safe to leave this UUID rev in the tree.
You need to log in
before you can comment on or make changes to this bug.
Description
•