577638 - Outdated comments in XPCOMUtils.jsm after Bug 568691

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[PikeUK]

As I understand it (which is not particularly well so this might be INVALID) Bug 568691 removed the ability of XPCOMUtils.jsm to register entries with the category manager. However the comments in XPCOMUtils.jsm still describe the unused _xpcom_categories object.

It's only mentioned in a couple of places now, two comments, one extension (that presumably retains it for backwards compatibility?) and one other place that I'm not sure about:

http://mxr.mozilla.org/mozilla-central/search?string=_xpcom_categories

Comment 1

[Nickolay_Ponomarev]

https://developer.mozilla.org/en/XPCOM/XPCOM_changes_in_Gecko_2.0#Category_registration seems to agree.

While we're there, step 3 in the XPCOMUtils comment still talks about NSGetModule and should be updated too.
http://mxr.mozilla.org/mozilla-central/source/js/src/xpconnect/loader/XPCOMUtils.jsm#98

Comment 2

[Benjamin Smedberg]

http://hg.mozilla.org/mozilla-central/rev/46973bbe4ef9

Comment 3

[PikeUK]

(In reply to comment #2)
> http://hg.mozilla.org/mozilla-central/rev/46973bbe4ef9

I notice that _xpcom_categories wasn't removed from the comment, not sure if that was deliberate or an oversight.

Comment 4

[Benjamin Smedberg]

It's in the "The following properties were used prior to Mozilla 2" section, so the comment is correct, no?

Comment 5

[PikeUK]

(In reply to comment #4)
> It's in the "The following properties were used prior to Mozilla 2" section, so
> the comment is correct, no?

Ok, I intepreted it as a separate section but now you say that it makes sense, thanks.