Closed Bug 577650 Opened 13 years ago Closed 13 years ago

Better handle closing the last visible tab

Categories

(Firefox Graveyard :: Panorama, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Mardak, Assigned: raymondlee)

Details

Attachments

(1 file)

Attached patch v1Splinter Review
+ Create two groups; one with a single tab and another with several
tabs. Go into the single tab and then close the tab. You return to the
TabCandy interface as you should, but you see one of the other tabs
zooming out. There should be no zoom out in this case. [RAYMOND]
+ Cmd+e key combination is not working in the tab candy.
+ close buttons on tabs are still not showing correctly.  Add a bunch
of tabs to the tabstrip so all close buttons for background tabs are
hidden, go into Tab Candy interface and remove tabs until you know the
close buttons should appear.  Then, zoom into a tab and the close
buttons on back
(In reply to comment #0)
> Created an attachment (id=456564) [details]
> v1
> 
> + Create two groups; one with a single tab and another with several
> tabs. Go into the single tab and then close the tab. You return to the
> TabCandy interface as you should, but you see one of the other tabs
> zooming out. There should be no zoom out in this case. [RAYMOND]
> + Cmd+e key combination is not working in the tab candy.
> + close buttons on tabs are still not showing correctly.  Add a bunch
> of tabs to the tabstrip so all close buttons for background tabs are
> hidden, go into Tab Candy interface and remove tabs until you know the
> close buttons should appear.  Then, zoom into a tab and the close
> buttons on back

Patch accepted, with a minor change.
http://hg.mozilla.org/users/edward.lee_engineering.uiuc.edu/tabcandy-central/rev/3a26196e6862
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Mass moving all Tab Candy bugs from Mozilla Labs to Firefox::Tab Candy.  Filter the bugmail spam with "tabcandymassmove".
Product: Mozilla Labs → Firefox
Target Milestone: -- → ---
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.